Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2779613004: Fix an assertion failure in the profiler (Closed)

Created:
3 years, 8 months ago by Cutch
Modified:
3 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix an assertion failure in the profiler - [x] Always reset the inlined functions cache before reusing an entry. Fixes #29173 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f7d570dab29227c1c73051669fa677524b23df21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/vm/profiler_service.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
3 years, 8 months ago (2017-03-27 19:25:59 UTC) #3
rmacnak
LGTM
3 years, 8 months ago (2017-03-27 19:29:09 UTC) #4
Cutch
3 years, 8 months ago (2017-03-27 19:29:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f7d570dab29227c1c73051669fa677524b23df21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698