Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2779553002: MD Downloads: hide some things from the a11y tree with role="none" so VoiceOver navigation works (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, dmazzoni
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: hide some things from the a11y tree with role="none" so VoiceOver navigation works R=aboxhall@chromium.org BUG=none NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2779553002 Cr-Commit-Position: refs/heads/master@{#461054} Committed: https://chromium.googlesource.com/chromium/src/+/fc68845df1f3a816c0bddcbf4f05f8e45b8e6e4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
Dan Beam
3 years, 8 months ago (2017-03-27 06:39:00 UTC) #2
Dan Beam
ping
3 years, 8 months ago (2017-03-28 06:11:15 UTC) #7
Dan Beam
ping
3 years, 8 months ago (2017-03-29 12:45:41 UTC) #9
Dan Beam
3 years, 8 months ago (2017-03-30 04:51:54 UTC) #11
aboxhall
lgtm
3 years, 8 months ago (2017-03-30 05:16:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779553002/1
3 years, 8 months ago (2017-03-30 13:32:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/183396)
3 years, 8 months ago (2017-03-30 15:55:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779553002/1
3 years, 8 months ago (2017-03-31 00:06:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/184136)
3 years, 8 months ago (2017-03-31 01:52:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779553002/1
3 years, 8 months ago (2017-03-31 05:57:27 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 06:06:34 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc68845df1f3a816c0bddcbf4f05...

Powered by Google App Engine
This is Rietveld 408576698