chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java - Issue 2779543005: Add support for highlighting menu items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java

Issue 2779543005: Add support for highlighting menu items (Closed)

Patch Set: Debugged drawable issues Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/PulseDrawableFactory.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java

index bbef9497ddb7e24a38305c8590fcbfffbadbf7c3..b08832117dd767405f4e663c4b1f2c6c8f3f452d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java

@@ -34,13 +34,13 @@ public class TabSwitcherCallout {

@TargetApi(Build.VERSION_CODES.LOLLIPOP)

public static TextBubble showIfNecessary(Context context, View tabSwitcherButton) {

- if (!isTabSwitcherCalloutNecessary()) return null;

+ // if (!isTabSwitcherCalloutNecessary()) return null;

Ted C 2017/04/12 18:05:57 ?

David Trainor- moved to gerrit 2017/04/12 18:59:37 Doesn't everyone want to see the tab switcher call

setIsTabSwitcherCalloutNecessary(false);

ViewAnchoredTextBubble bubble = new ViewAnchoredTextBubble(

context, tabSwitcherButton, R.string.tab_switcher_callout_body);

bubble.setDismissOnTouchInteraction(true);

- bubble.setAutoDismissTimeout(TAB_SWITCHER_CALLOUT_DISMISS_MS);

+ // bubble.setAutoDismissTimeout(TAB_SWITCHER_CALLOUT_DISMISS_MS);

int yInsetPx = (int) (Y_OVERLAP_DP * context.getResources().getDisplayMetrics().density);

bubble.setInsetPx(0, yInsetPx, 0, yInsetPx);

bubble.show();