Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 2779533002: Revert of Mojo JS bindings: change module loading solution. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index 4a244fb5b11de7f387a8b454e9c5bedd861410f5..246663672eb281df9fd5c3befbaf54f588e214d8 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -133,13 +133,6 @@
#
# cpp_only (optional)
# If set to true, only the C++ bindings targets will be generated.
-#
-# use_new_js_bindings (optional)
-# If set to true, the generated JS code will use the new module loading
-# approach and the core API exposed by Web IDL.
-#
-# TODO(yzshen): Switch all existing users to use_new_js_bindings=true and
-# remove the old mode.
#
# The following parameters are used to support the component build. They are
# needed so that bindings which are linked with a component can use the same
@@ -441,11 +434,6 @@
if (defined(invoker.use_once_callback) && invoker.use_once_callback) {
args += [ "--use_once_callback" ]
}
-
- if (defined(invoker.use_new_js_bindings) &&
- invoker.use_new_js_bindings) {
- args += [ "--use_new_js_bindings" ]
- }
}
}
« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_js_generator.py ('k') | mojo/public/tools/bindings/mojom_bindings_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698