Fix nullptr deref in ChildThreadImpl

content/child/child_thread_impl.cc

Index: content/child/child_thread_impl.cc
diff --git a/content/child/child_thread_impl.cc b/content/child/child_thread_impl.cc
index 1369ba4faf3cfaf89b07dee0f7800ce4a86b1837..c72163ee6043d77046d8502187e3bf5186ca4f6d 100644
--- a/content/child/child_thread_impl.cc
+++ b/content/child/child_thread_impl.cc
@@ -503,13 +503,14 @@ void ChildThreadImpl::Init(const Options& options) {
         ChildProcess::current()->io_task_runner()));
     channel_->AddFilter(new ChildMemoryMessageFilter());
 
-    memory_instrumentation::MemoryDumpManagerDelegateImpl::Config config(
-        GetConnector(), mojom::kBrowserServiceName);
-    auto delegate =
-        base::MakeUnique<memory_instrumentation::MemoryDumpManagerDelegateImpl>(
-            config);
-    base::trace_event::MemoryDumpManager::GetInstance()->Initialize(
-        std::move(delegate));
+    if (GetConnector()) {

[Lei Zhang, 2017/03/25 01:56:34]

GetConnector() is service_manager_connection_->GetConnector() underneath. So
maybe |service_manager_connection_| is a nullptr? In which case, this won't be
affective.

You may be on the right track, because the code below on line 519 affected the
Cloud Print Connector as well.

[Ken Rockot(use gerrit already), 2017/03/25 02:02:48]

Thanks. Fixed. /shamecube

+      memory_instrumentation::MemoryDumpManagerDelegateImpl::Config config(
+          GetConnector(), mojom::kBrowserServiceName);
+      auto delegate = base::MakeUnique<
+          memory_instrumentation::MemoryDumpManagerDelegateImpl>(config);
+      base::trace_event::MemoryDumpManager::GetInstance()->Initialize(
+          std::move(delegate));
+    }
   }
 
   // In single process mode we may already have a power monitor,