Duplicate process handle in process_metrics_win.cc

base/process/process_metrics_win.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/process_metrics.h"
 
 #include <windows.h>
 #include <psapi.h>
 #include <stddef.h>
 #include <stdint.h>
@@ skipping 13 matching lines @@
 const int PAGESIZE_KB = 4;
 
 typedef NTSTATUS(WINAPI* NTQUERYSYSTEMINFORMATION)(
     SYSTEM_INFORMATION_CLASS SystemInformationClass,
     PVOID SystemInformation,
     ULONG SystemInformationLength,
     PULONG ReturnLength);
 
 }  // namespace
 
-ProcessMetrics::~ProcessMetrics() { }
+ProcessMetrics::~ProcessMetrics() {
+  if (process_)
+    ::CloseHandle(process_);

[brucedawson, 2017/03/30 23:09:46]

Shouldn't this use a handle wrapper class rather than explicitly closing and
initializing the handle?

[stanisc, 2017/03/30 23:24:34]

It should, but process_ field is defined in the header file which is shared
between all platforms.

+}
 
 // static
 std::unique_ptr<ProcessMetrics> ProcessMetrics::CreateProcessMetrics(
     ProcessHandle process) {
   return WrapUnique(new ProcessMetrics(process));
 }
 
 size_t ProcessMetrics::GetPagefileUsage() const {
   PROCESS_MEMORY_COUNTERS pmc;
   if (GetProcessMemoryInfo(process_, &pmc, sizeof(pmc))) {
@@ skipping 267 matching lines @@
   last_cpu_time_ = time;
 
   return static_cast<double>(system_time_delta * 100.0) / time_delta;
 }
 
 bool ProcessMetrics::GetIOCounters(IoCounters* io_counters) const {
   return GetProcessIoCounters(process_, io_counters) != FALSE;
 }
 
 ProcessMetrics::ProcessMetrics(ProcessHandle process)
-    : process_(process),
+    : process_(nullptr),
       processor_count_(SysInfo::NumberOfProcessors()),
-      last_system_time_(0) {}
+      last_system_time_(0) {
+  if (process) {
+    BOOL result =
+        ::DuplicateHandle(::GetCurrentProcess(), process, ::GetCurrentProcess(),
+                          &process_, PROCESS_QUERY_INFORMATION, FALSE, 0);
+    DCHECK(result);
+  }
+}
 
 size_t GetSystemCommitCharge() {
   // Get the System Page Size.
   SYSTEM_INFO system_info;
   GetSystemInfo(&system_info);
 
   PERFORMANCE_INFORMATION info;
   if (!GetPerformanceInfo(&info, sizeof(info))) {
     DLOG(ERROR) << "Failed to fetch internal performance info.";
     return 0;
@@ skipping 19 matching lines @@
 
   meminfo->total = mem_status.ullTotalPhys / 1024;
   meminfo->avail_phys = mem_status.ullAvailPhys / 1024;
   meminfo->swap_total = mem_status.ullTotalPageFile / 1024;
   meminfo->swap_free = mem_status.ullAvailPageFile / 1024;
 
   return true;
 }
 
 }  // namespace base