Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2779383002: implement user agent override option. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index b5e12d3765c2add415dff86d912e2a3beaf136a6..bd0b981cd3a55339c5e25f1fc4d773be676fbac9 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -622,8 +622,6 @@ + (Tab*)preloadingTabWithBrowserState:(ios::ChromeBrowserState*)browserState
opener:opener
openedByDOM:NO
model:nil] autorelease];
- if (desktopUserAgent)
- [tab enableDesktopUserAgent];
[[tab webController] setNativeProvider:provider];
[[tab webController] setWebUsageEnabled:YES];
@@ -633,6 +631,11 @@ + (Tab*)preloadingTabWithBrowserState:(ios::ChromeBrowserState*)browserState
web::NavigationManager::WebLoadParams params(URL);
params.transition_type = transition;
params.referrer = referrer;
+ if (desktopUserAgent) {
+ params.user_agent_override_option =
+ web::NavigationManager::UserAgentOverrideOption::DESKTOP;
+ }
+
[[tab webController] loadWithParams:params];
return tab;
@@ -1484,12 +1487,6 @@ - (BOOL)usesDesktopUserAgent {
visibleItem->GetUserAgentType() == web::UserAgentType::DESKTOP;
}
-- (void)enableDesktopUserAgent {
- DCHECK_EQ(self.usesDesktopUserAgent, NO);
- DCHECK([self navigationManager]);
- [self navigationManager]->OverrideDesktopUserAgentForNextPendingItem();
-}
-
- (void)reloadForDesktopUserAgent {
// This removes the web view, which will be recreated at the end of this.
[self.webController requirePageReconstruction];
@@ -1514,6 +1511,8 @@ - (void)reloadForDesktopUserAgent {
web::NavigationManager::WebLoadParams params(reloadURL);
params.referrer = lastNonRedirectedItem->GetReferrer();
// A new navigation is needed here for reloading with desktop User-Agent.
+ params.user_agent_override_option =
+ web::NavigationManager::UserAgentOverrideOption::DESKTOP;
params.transition_type =
ui::PageTransitionFromInt(ui::PAGE_TRANSITION_FORM_SUBMIT);
navigationManager->LoadURLWithParams(params);

Powered by Google App Engine
This is Rietveld 408576698