Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/navigation/navigation_manager_impl_unittest.mm

Issue 2779383002: implement user agent override option. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/navigation_manager_impl.mm ('k') | ios/web/public/navigation_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/navigation_manager_impl_unittest.mm
diff --git a/ios/web/navigation/navigation_manager_impl_unittest.mm b/ios/web/navigation/navigation_manager_impl_unittest.mm
index 2b3f2229ef1b73dcc3418e88e27344018b5c2b6c..b777003c5ee6800c2f48b796683fbddd31749cb1 100644
--- a/ios/web/navigation/navigation_manager_impl_unittest.mm
+++ b/ios/web/navigation/navigation_manager_impl_unittest.mm
@@ -72,7 +72,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, GetPendingItemIndexWithoutPendingEntry) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
EXPECT_EQ(-1, navigation_manager()->GetPendingItemIndex());
}
@@ -82,11 +83,13 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, GetPendingItemIndexWithPendingEntry) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
EXPECT_EQ(0, navigation_manager()->GetPendingItemIndex());
}
@@ -95,11 +98,13 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, GetPendingItemIndexWithIndexedPendingEntry) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
EXPECT_EQ(-1, navigation_manager()->GetPendingItemIndex());
@@ -128,7 +133,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, CanGoBackWithTransientItemAndCommittedItem) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
[session_controller() addTransientItemWithURL:GURL("http://www.url.com/0")];
@@ -141,7 +147,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, CanGoBackWithSingleCommitedItem) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
EXPECT_FALSE(navigation_manager()->CanGoBack());
@@ -152,15 +159,18 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, CanGoBackWithMultipleCommitedItems) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/1"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
EXPECT_TRUE(navigation_manager()->CanGoBack());
@@ -191,7 +201,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, CanGoForwardWithSingleCommitedItem) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
EXPECT_FALSE(navigation_manager()->CanGoForward());
@@ -202,15 +213,18 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, CanGoForwardWithMultipleCommitedEntries) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/1"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
EXPECT_FALSE(navigation_manager()->CanGoForward());
@@ -239,25 +253,30 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, OffsetsWithoutPendingIndex) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_LINK,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/redirect"), Referrer(),
ui::PAGE_TRANSITION_CLIENT_REDIRECT,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/1"), Referrer(), ui::PAGE_TRANSITION_LINK,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/2"), Referrer(), ui::PAGE_TRANSITION_LINK,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/redirect"), Referrer(),
ui::PAGE_TRANSITION_CLIENT_REDIRECT,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
ASSERT_EQ(5, navigation_manager()->GetItemCount());
ASSERT_EQ(4, navigation_manager()->GetLastCommittedItemIndex());
@@ -463,15 +482,18 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
// to it (pending index is 1, current index is 2).
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_LINK,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/1"), Referrer(), ui::PAGE_TRANSITION_LINK,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/2"), Referrer(), ui::PAGE_TRANSITION_LINK,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
[session_controller() addTransientItemWithURL:GURL("http://www.url.com/1")];
[session_controller() setPendingItemIndex:1];
@@ -493,46 +515,113 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
EXPECT_EQ(0, navigation_manager()->GetIndexForOffset(-1));
}
-// Tests that desktop user agent can be enforced to use for next pending item.
-TEST_F(NavigationManagerTest, OverrideDesktopUserAgent) {
- navigation_manager()->OverrideDesktopUserAgentForNextPendingItem();
+// Tests that desktop user agent can be enforced to use for next pending item
+// when UserAgentOverrideOption is DESKTOP.
+TEST_F(NavigationManagerTest, OverrideUserAgentWithDesktop) {
navigation_manager()->AddPendingItem(
- GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ GURL("http://www.1.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
- NavigationItem* visible_item = navigation_manager()->GetVisibleItem();
- EXPECT_EQ(visible_item->GetUserAgentType(), UserAgentType::DESKTOP);
+ NavigationItem* last_committed_item =
+ navigation_manager()->GetLastCommittedItem();
+ EXPECT_EQ(UserAgentType::MOBILE, last_committed_item->GetUserAgentType());
+
+ navigation_manager()->AddPendingItem(
+ GURL("http://www.2.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::DESKTOP);
+ ASSERT_TRUE(navigation_manager()->GetPendingItem());
+ EXPECT_EQ(UserAgentType::DESKTOP,
+ navigation_manager()->GetPendingItem()->GetUserAgentType());
}
-// Tests that the UserAgentType is propagated to subsequent NavigationItems.
-TEST_F(NavigationManagerTest, UserAgentTypePropagation) {
- // Add and commit two NavigationItems.
+// Tests that mobile user agent can be enforced to use for next pending item
+// when UserAgentOverrideOption is MOBILE.
+TEST_F(NavigationManagerTest, OverrideUserAgentWithMobile) {
navigation_manager()->AddPendingItem(
GURL("http://www.1.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
- web::NavigationItem* item1 = navigation_manager()->GetLastCommittedItem();
- ASSERT_EQ(web::UserAgentType::MOBILE, item1->GetUserAgentType());
+ NavigationItem* last_committed_item =
+ navigation_manager()->GetLastCommittedItem();
+ last_committed_item->SetUserAgentType(UserAgentType::DESKTOP);
+ EXPECT_EQ(UserAgentType::DESKTOP, last_committed_item->GetUserAgentType());
+
navigation_manager()->AddPendingItem(
GURL("http://www.2.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::MOBILE);
+ ASSERT_TRUE(navigation_manager()->GetPendingItem());
+ EXPECT_EQ(UserAgentType::MOBILE,
+ navigation_manager()->GetPendingItem()->GetUserAgentType());
+}
+
+// Tests that the UserAgentType of an INHERIT item is propagated to subsequent
+// item when UserAgentOverrideOption is INHERIT
+TEST_F(NavigationManagerTest, OverrideUserAgentWithInheritAfterInherit) {
+ navigation_manager()->AddPendingItem(
+ GURL("http://www.1.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
- web::NavigationItem* item2 = navigation_manager()->GetLastCommittedItem();
+ ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
+ EXPECT_EQ(web::UserAgentType::MOBILE,
+ navigation_manager()->GetLastCommittedItem()->GetUserAgentType());
- // Verify that the second item's UserAgentType is equal to the first.
- EXPECT_EQ(item1->GetUserAgentType(), item2->GetUserAgentType());
+ navigation_manager()->AddPendingItem(
+ GURL("http://www.2.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
+ [session_controller() commitPendingItem];
+ ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
+ EXPECT_EQ(web::UserAgentType::MOBILE,
+ navigation_manager()->GetLastCommittedItem()->GetUserAgentType());
+}
- // Update |item2|'s UA type to DESKTOP and commit a new item.
- item2->SetUserAgentType(web::UserAgentType::DESKTOP);
- ASSERT_EQ(web::UserAgentType::DESKTOP, item2->GetUserAgentType());
+// Tests that the UserAgentType of a MOBILE item is propagated to subsequent
+// item when UserAgentOverrideOption is INHERIT
+TEST_F(NavigationManagerTest, OverrideUserAgentWithInheritAfterMobile) {
navigation_manager()->AddPendingItem(
- GURL("http://www.3.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ GURL("http://www.1.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::MOBILE);
[session_controller() commitPendingItem];
- web::NavigationItem* item3 = navigation_manager()->GetLastCommittedItem();
+ ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
+ EXPECT_EQ(web::UserAgentType::MOBILE,
+ navigation_manager()->GetLastCommittedItem()->GetUserAgentType());
- // Verify that the third item's UserAgentType is equal to the second.
- EXPECT_EQ(item2->GetUserAgentType(), item3->GetUserAgentType());
+ navigation_manager()->AddPendingItem(
+ GURL("http://www.2.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
+ [session_controller() commitPendingItem];
+ ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
+ EXPECT_EQ(web::UserAgentType::MOBILE,
+ navigation_manager()->GetLastCommittedItem()->GetUserAgentType());
+}
+
+// Tests that the UserAgentType of a DESKTOP item is propagated to subsequent
+// item when UserAgentOverrideOption is INHERIT
+TEST_F(NavigationManagerTest, OverrideUserAgentWithInheritAfterDesktop) {
+ navigation_manager()->AddPendingItem(
+ GURL("http://www.1.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::DESKTOP);
+ [session_controller() commitPendingItem];
+ ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
+ EXPECT_EQ(web::UserAgentType::DESKTOP,
+ navigation_manager()->GetLastCommittedItem()->GetUserAgentType());
+
+ navigation_manager()->AddPendingItem(
+ GURL("http://www.2.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
+ [session_controller() commitPendingItem];
+ ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
+ EXPECT_EQ(web::UserAgentType::DESKTOP,
+ navigation_manager()->GetLastCommittedItem()->GetUserAgentType());
}
// Tests that the UserAgentType is propagated to subsequent NavigationItems if
@@ -546,20 +635,23 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
// Create two non-native navigations that are separated by a native one.
navigation_manager()->AddPendingItem(
GURL("http://www.1.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
web::NavigationItem* item1 = navigation_manager()->GetLastCommittedItem();
ASSERT_EQ(web::UserAgentType::MOBILE, item1->GetUserAgentType());
navigation_manager()->AddPendingItem(
item1->GetURL().ReplaceComponents(native_scheme_replacement), Referrer(),
- ui::PAGE_TRANSITION_TYPED, web::NavigationInitiationType::USER_INITIATED);
+ ui::PAGE_TRANSITION_TYPED, web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
web::NavigationItem* native_item1 =
navigation_manager()->GetLastCommittedItem();
ASSERT_EQ(web::UserAgentType::NONE, native_item1->GetUserAgentType());
navigation_manager()->AddPendingItem(
GURL("http://www.2.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
web::NavigationItem* item2 = navigation_manager()->GetLastCommittedItem();
@@ -572,14 +664,16 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
ASSERT_EQ(web::UserAgentType::DESKTOP, item2->GetUserAgentType());
navigation_manager()->AddPendingItem(
item2->GetURL().ReplaceComponents(native_scheme_replacement), Referrer(),
- ui::PAGE_TRANSITION_TYPED, web::NavigationInitiationType::USER_INITIATED);
+ ui::PAGE_TRANSITION_TYPED, web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
web::NavigationItem* native_item2 =
navigation_manager()->GetLastCommittedItem();
ASSERT_EQ(web::UserAgentType::NONE, native_item2->GetUserAgentType());
navigation_manager()->AddPendingItem(
GURL("http://www.3.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
web::NavigationItem* item3 = navigation_manager()->GetLastCommittedItem();
@@ -609,7 +703,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
GURL url_before_reload = GURL("http://www.url.com");
navigation_manager()->AddPendingItem(
url_before_reload, Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::RENDERER_INITIATED);
+ web::NavigationInitiationType::RENDERER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
navigation_manager()->Reload(web::ReloadType::NORMAL,
false /* check_for_repost */);
@@ -626,7 +721,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
GURL url_before_reload = GURL("http://www.url.com");
navigation_manager()->AddPendingItem(
url_before_reload, Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
navigation_manager()->Reload(web::ReloadType::NORMAL,
false /* check_for_repost */);
@@ -642,13 +738,15 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, ReloadLastCommittedItemWithNormalType) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
GURL url_before_reload = GURL("http://www.url.com/1");
navigation_manager()->AddPendingItem(
url_before_reload, Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->Reload(web::ReloadType::NORMAL,
@@ -667,18 +765,21 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
ReloadLastCommittedItemWithNormalTypeWithForwardItems) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
GURL url_before_reload = GURL("http://www.url.com/1");
navigation_manager()->AddPendingItem(
url_before_reload, Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/2"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
[session_controller() goToItemAtIndex:1];
@@ -715,7 +816,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, ReloadRendererPendingItemWithOriginalType) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::RENDERER_INITIATED);
+ web::NavigationInitiationType::RENDERER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
ASSERT_TRUE(navigation_manager()->GetPendingItem());
GURL expected_original_url = GURL("http://www.url.com/original");
navigation_manager()->GetPendingItem()->SetOriginalRequestURL(
@@ -736,7 +838,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, ReloadUserPendingItemWithOriginalType) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
ASSERT_TRUE(navigation_manager()->GetPendingItem());
GURL expected_original_url = GURL("http://www.url.com/original");
navigation_manager()->GetPendingItem()->SetOriginalRequestURL(
@@ -757,12 +860,14 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
TEST_F(NavigationManagerTest, ReloadLastCommittedItemWithOriginalType) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/1"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
GURL expected_original_url = GURL("http://www.url.com/1/original");
ASSERT_TRUE(navigation_manager()->GetPendingItem());
navigation_manager()->GetPendingItem()->SetOriginalRequestURL(
@@ -785,12 +890,14 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
ReloadLastCommittedItemWithOriginalTypeWithForwardItems) {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/0"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/1"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
GURL expected_original_url = GURL("http://www.url.com/1/original");
ASSERT_TRUE(navigation_manager()->GetPendingItem());
navigation_manager()->GetPendingItem()->SetOriginalRequestURL(
@@ -799,7 +906,8 @@ TestNavigationManagerDelegate navigation_manager_delegate() {
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/2"), Referrer(), ui::PAGE_TRANSITION_TYPED,
- web::NavigationInitiationType::USER_INITIATED);
+ web::NavigationInitiationType::USER_INITIATED,
+ web::NavigationManager::UserAgentOverrideOption::INHERIT);
[session_controller() commitPendingItem];
[session_controller() goToItemAtIndex:1];
« no previous file with comments | « ios/web/navigation/navigation_manager_impl.mm ('k') | ios/web/public/navigation_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698