Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 2779373004: [dart:io][windows] Set the last error when a signal is unsupported (Closed)

Created:
3 years, 8 months ago by zra
Modified:
3 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io][windows] Set the last error when a signal is unsupported fixes #28603 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/cc10a46a1dbc130f0d738cb30134b10b39c197f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/bin/process_win.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 8 months ago (2017-03-29 22:31:16 UTC) #2
Florian Schneider
lgtm
3 years, 8 months ago (2017-03-29 22:34:07 UTC) #3
zra
3 years, 8 months ago (2017-03-29 22:39:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc10a46a1dbc130f0d738cb30134b10b39c197f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698