chrome/browser/ui/views/payments/payment_request_sheet_controller.cc - Issue 2779283002: [Web Payments] Implement the CVC Unmask dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

Issue 2779283002: [Web Payments] Implement the CVC Unmask dialog. (Closed)

Patch Set: Fix components_unittests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h ('K') | « chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc ('k') | chrome/test/BUILD.gn » ('j') | components/payments/content/payment_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

index 7bd16435039c7296e3b19d6312340364cc37daa5..671b2a0ef5a0c1d77a6260c35976a8d0db4160df 100644

--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

@@ -111,6 +111,7 @@ PaymentRequestSheetController::CreatePaymentView() {

pane_columns->AddColumn(

views::GridLayout::Alignment::FILL, views::GridLayout::Alignment::LEADING,

0, views::GridLayout::SizeType::FIXED, kDialogWidth, kDialogWidth);

Mathieu 2017/04/04 19:05:48 we could revert this line and thus file

anthonyvd 2017/04/04 23:02:14 Good catch, done.

pane->SetLayoutManager(pane_layout);

pane_layout->StartRow(0, 0);

pane_layout->AddView(content_view_);