[Web Payments] Implement the CVC Unmask dialog.

components/payments/core/autofill_payment_instrument.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/core/autofill_payment_instrument.h"
 
 #include "base/json/json_writer.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/payments/core/basic_card_response.h"
 #include "components/payments/core/payment_request_data_util.h"
 
 namespace payments {
 
 AutofillPaymentInstrument::AutofillPaymentInstrument(
     const std::string& method_name,
     const autofill::CreditCard& card,
     const std::vector<autofill::AutofillProfile*>& billing_profiles,
-    const std::string& app_locale)
+    const std::string& app_locale,
+    FullCardRequestDelegate* full_card_request_delegate)
     : PaymentInstrument(
           method_name,
           /* label= */ card.TypeAndLastFourDigits(),
           /* sublabel= */
           card.GetInfo(autofill::AutofillType(autofill::CREDIT_CARD_NAME_FULL),
                        app_locale),
           autofill::data_util::GetPaymentRequestData(card.type())
               .icon_resource_id),
       credit_card_(card),
       billing_profiles_(billing_profiles),
-      app_locale_(app_locale) {}
+      app_locale_(app_locale),
+      delegate_(nullptr),
+      full_card_request_delegate_(full_card_request_delegate),
+      weak_ptr_factory_(this) {}
 AutofillPaymentInstrument::~AutofillPaymentInstrument() {}
 
 void AutofillPaymentInstrument::InvokePaymentApp(
     PaymentInstrument::Delegate* delegate) {
   DCHECK(delegate);

[please use gerrit instead, 2017/03/30 13:14:09]

DCHECK(!delegate_);

[anthonyvd, 2017/03/30 15:43:41]

I don't think that's correct. For example, we could call InvokePaymentApp to
show the CVC prompt for a card, the user could hit back, then "Pay" again, and
we'd end up re-entering this function. In that case, we want to overwrite
|delegate_|. 

[please use gerrit instead, 2017/03/31 14:41:14]

If the user hits back, then "delegate_ = null" code in OnFullCardRequestFailed()
will be triggered. The DHCECK(!delegate_) is needed to prevent a bug where you
call InvokePaymentApp() twice by accident without OnFullCardRequestFailed()
being called.

[anthonyvd, 2017/04/04 13:25:22]

Makes sense, done.

-  std::string stringified_details;
-  // TODO(mathp): Show the CVC dialog and use the data instead of the
-  // placeholder string.
-  std::unique_ptr<base::DictionaryValue> response_value =
-      payments::data_util::GetBasicCardResponseFromAutofillCreditCard(
-          credit_card_, base::ASCIIToUTF16("123"), billing_profiles_,
-          app_locale_)
-          .ToDictionaryValue();
-  base::JSONWriter::Write(*response_value, &stringified_details);
-  delegate->OnInstrumentDetailsReady(method_name(), stringified_details);
+  delegate_ = delegate;
+
+  full_card_request_delegate_->DoFullCardRequest(
+      credit_card_, weak_ptr_factory_.GetWeakPtr());
 }
 
 bool AutofillPaymentInstrument::IsValid() {
   return credit_card_.IsValid();
 }
 
+void AutofillPaymentInstrument::OnFullCardRequestSucceeded(
+    const autofill::CreditCard& card,
+    const base::string16& cvc) {
+  DCHECK(delegate_);
+  credit_card_ = card;
+  std::string stringified_details;
+  std::unique_ptr<base::DictionaryValue> response_value =
+      payments::data_util::GetBasicCardResponseFromAutofillCreditCard(
+          credit_card_, cvc, billing_profiles_, app_locale_)
+          .ToDictionaryValue();
+  base::JSONWriter::Write(*response_value, &stringified_details);
+  delegate_->OnInstrumentDetailsReady(method_name(), stringified_details);

[please use gerrit instead, 2017/03/30 13:14:10]

delegate_ = nullptr;

[anthonyvd, 2017/03/30 15:43:41]

Done.

+}
+
+void AutofillPaymentInstrument::OnFullCardRequestFailed() {}
+
 }  // namespace payments