[Web Payments] Implement the CVC Unmask dialog.

chrome/browser/payments/chrome_payment_request_delegate.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/payments/chrome_payment_request_delegate.h"
 
 #include "base/macros.h"

[please use gerrit instead, 2017/03/30 13:14:09]

Already included in the header, so not needed in here.

[anthonyvd, 2017/03/30 15:43:40]

Done.

 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_dialogs.h"
+#include "components/autofill/content/browser/content_autofill_driver.h"
+#include "components/autofill/content/browser/content_autofill_driver_factory.h"
 #include "components/payments/content/payment_request_dialog.h"
 #include "content/public/browser/web_contents.h"
 
 namespace payments {
 
 ChromePaymentRequestDelegate::ChromePaymentRequestDelegate(
     content::WebContents* web_contents)
     : dialog_(nullptr), web_contents_(web_contents) {}
 
 void ChromePaymentRequestDelegate::ShowDialog(PaymentRequest* request) {
@@ skipping 23 matching lines @@
 const std::string& ChromePaymentRequestDelegate::GetApplicationLocale() const {
   return g_browser_process->GetApplicationLocale();
 }
 
 bool ChromePaymentRequestDelegate::IsIncognito() const {
   Profile* profile =
       Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   return profile && profile->GetProfileType() == Profile::INCOGNITO_PROFILE;
 }
 
+void ChromePaymentRequestDelegate::DoFullCardRequest(
+    const autofill::CreditCard& credit_card,
+    base::WeakPtr<autofill::payments::FullCardRequest::ResultDelegate>
+        result_delegate) {
+  autofill::ContentAutofillDriverFactory* factory =

[Mathieu, 2017/03/30 14:37:32]

I don't like this dependence on the AutofillManager. 

Let's do a couple of things so that we don't need it:

(1) full_card_request, card_unmask_delegate and payments_client 
 should really be in components/payments/core (optional)
   (1b) You will need to remove the dependence to AutofillClient* by instead
having AutofillClient implement risk_util.h (move to components) and pass that
to FullCardRequest. May need to have risk_util_impl.h/cc in
chrome/browser/autofill

(2) In this file, dialog_->ShowCvcUnmaskPrompt(credit_card, result_delegate)

(3) Ultimately the Cvc view controller should get all the things and be able to
create and hold on to the FullCardRequest!
  (3b) When it needs to pass the RiskUtil* to FullCardRequest, it can get it
from RiskUtilImpl (in chrome/browser/autofill).

+      autofill::ContentAutofillDriverFactory::FromWebContents(web_contents_);
+  autofill::ContentAutofillDriver* driver =
+      factory->DriverForFrame(web_contents_->GetMainFrame());
+  autofill::payments::FullCardRequest* request =
+      driver->autofill_manager()->GetOrCreateFullCardRequest();
+
+  request->GetFullCard(
+      credit_card, autofill::AutofillClient::UNMASK_FOR_PAYMENT_REQUEST,
+      result_delegate, dialog_->GetFullCardRequestUIDelegate());
+}
+
 }  // namespace payments