third_party/WebKit/Source/platform/KeyboardCodes.h - Issue 2779273003: [Media Controls] Add UMA for timeline scrubber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/KeyboardCodes.h

Issue 2779273003: [Media Controls] Add UMA for timeline scrubber (Closed)

Patch Set: Address isherman's review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/KeyboardCodes.h

diff --git a/third_party/WebKit/Source/platform/KeyboardCodes.h b/third_party/WebKit/Source/platform/KeyboardCodes.h

index 0c946388900e113c1958af2804efb47595731a20..e2e5f37cea49c25fef82356878b0d833e5a261fc 100644

--- a/third_party/WebKit/Source/platform/KeyboardCodes.h

+++ b/third_party/WebKit/Source/platform/KeyboardCodes.h

@@ -31,6 +31,8 @@

#ifndef KeyboardCodes_h

#define KeyboardCodes_h

+#include "platform/wtf/build_config.h"

esprehn 2017/04/04 18:56:02 Why is this needed?

johnme 2017/04/06 16:23:26 Because OS(WIN) below requires the OS macro define

#if OS(WIN)

#include <windows.h>

#endif