third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp - Issue 2779273003: [Media Controls] Add UMA for timeline scrubber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Issue 2779273003: [Media Controls] Add UMA for timeline scrubber (Closed)

Patch Set: Add a few more comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/shadow/MediaControlTimelineMetrics.cpp ('K') | « third_party/WebKit/Source/core/html/shadow/MediaControls.cpp ('k') | third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

index 070f17b32971c62841984ede8a0b15d1d8086e8d..28e05cee7f1a1a0e784df0269d1ce71b9b39f0a1 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

@@ -88,6 +88,10 @@ void MediaControlsMediaEventListener::handleEvent(

m_mediaControls->onPlay();

return;

}

+ if (event->type() == EventTypeNames::playing) {

+ m_mediaControls->onPlaying();

+ return;

+ }

if (event->type() == EventTypeNames::pause) {

m_mediaControls->onPause();

return;