Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2779273003: [Media Controls] Add UMA for timeline scrubber (Closed)
Patch Set: Add a few more comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
index df272a9493bee9dd77330ad7c5154beb82b50715..7dd54fe3f351688432416664822f76984baba687 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
@@ -31,6 +31,7 @@
#define MediaControlElements_h
#include "core/html/shadow/MediaControlElementTypes.h"
+#include "core/html/shadow/MediaControlTimelineMetrics.h"
#include "public/platform/WebLocalizedString.h"
namespace blink {
@@ -273,11 +274,19 @@ class MediaControlTimelineElement final : public MediaControlInputElement {
void setPosition(double);
void setDuration(double);
+ void onPlaying();
+
private:
explicit MediaControlTimelineElement(MediaControls&);
void defaultEventHandler(Event*) override;
bool keepEventInNode(Event*) override;
+
+ // Width in CSS pixels * pageZoomFactor (ignores CSS transforms for
+ // simplicity; deliberately ignores pinch zoom's pageScaleFactor).
+ int timelineWidth();
+
+ MediaControlTimelineMetrics m_metrics;
};
// ----------------------------

Powered by Google App Engine
This is Rietveld 408576698