Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/platform/Histogram.h

Issue 2779273003: [Media Controls] Add UMA for timeline scrubber (Closed)
Patch Set: Appease MSVC Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/Histogram.h
diff --git a/third_party/WebKit/Source/platform/Histogram.h b/third_party/WebKit/Source/platform/Histogram.h
index 1eb368762e9c7d8d8f273dac4c38b03276c01275..0d5c116fa62738a6fdaccbee09e04ac64dc7c21e 100644
--- a/third_party/WebKit/Source/platform/Histogram.h
+++ b/third_party/WebKit/Source/platform/Histogram.h
@@ -19,6 +19,7 @@ namespace blink {
class PLATFORM_EXPORT CustomCountHistogram {
public:
+ // Min values should be >=1 as emitted 0s still go into the underflow bucket.
CustomCountHistogram(const char* name,
base::HistogramBase::Sample min,
base::HistogramBase::Sample max,
@@ -38,6 +39,7 @@ class PLATFORM_EXPORT BooleanHistogram : public CustomCountHistogram {
class PLATFORM_EXPORT EnumerationHistogram : public CustomCountHistogram {
public:
+ // |boundaryValue| must be strictly greater than samples passed to |count|.
EnumerationHistogram(const char* name,
base::HistogramBase::Sample boundaryValue);
};

Powered by Google App Engine
This is Rietveld 408576698