third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp - Issue 2779273003: [Media Controls] Add UMA for timeline scrubber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

Issue 2779273003: [Media Controls] Add UMA for timeline scrubber (Closed)

Patch Set: Appease MSVC Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h ('k') | third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

index 402230417b10ac62781469052557d3177e51ee4e..ede6637936cc9516feb5b0572c865f20e4abad2e 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

@@ -866,6 +866,10 @@ void MediaControlsImpl::onPlay() {

startHideMediaControlsTimer();

}

+void MediaControlsImpl::onPlaying() {

+ m_timeline->onPlaying();

void MediaControlsImpl::onPause() {

updatePlayState();

m_timeline->setPosition(mediaElement().currentTime());