third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp - Issue 2779273003: [Media Controls] Add UMA for timeline scrubber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

Issue 2779273003: [Media Controls] Add UMA for timeline scrubber (Closed)

Patch Set: Appease MSVC Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

index d5ca0fc2a5c53c3e520fcf5f23f6fd2f6cd929ba..bbdf04317833605b1495803ee45c04d07fbd4aca 100644

--- a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

@@ -341,6 +341,7 @@ void SliderContainerElement::handleTouchEvent(TouchEvent* event) {

return;

if (event->type() == EventTypeNames::touchend) {

+ // TODO: Also do this for touchcancel?

input->dispatchFormControlChangeEvent();

event->setDefaultHandled();

m_slidingDirection = NoMove;