third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp - Issue 2779273003: [Media Controls] Add UMA for timeline scrubber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

Issue 2779273003: [Media Controls] Add UMA for timeline scrubber (Closed)

Patch Set: Appease MSVC Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlTimelineMetrics.cpp ('k') | third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

index 19a7ecec16d7ee6f7bd9d6c74393d4e69127a33b..d49d069ca7326b8943b12f03022542c63111bb26 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

@@ -25,6 +25,7 @@ void MediaControlsMediaEventListener::attach() {

mediaElement().addEventListener(EventTypeNames::focusin, this, false);

mediaElement().addEventListener(EventTypeNames::timeupdate, this, false);

mediaElement().addEventListener(EventTypeNames::play, this, false);

+ mediaElement().addEventListener(EventTypeNames::playing, this, false);

mediaElement().addEventListener(EventTypeNames::pause, this, false);

mediaElement().addEventListener(EventTypeNames::durationchange, this, false);

mediaElement().addEventListener(EventTypeNames::error, this, false);

@@ -88,6 +89,10 @@ void MediaControlsMediaEventListener::handleEvent(

m_mediaControls->onPlay();

return;

}

+ if (event->type() == EventTypeNames::playing) {

+ m_mediaControls->onPlaying();

+ return;

+ }

if (event->type() == EventTypeNames::pause) {

m_mediaControls->onPause();

return;