Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: ios/web/navigation/navigation_manager_impl.h

Issue 2779263002: Set user agent type of transient item the same as pending item. (Closed)
Patch Set: removed unused includes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 void OnNavigationItemCommitted(); 88 void OnNavigationItemCommitted();
89 89
90 // Temporary accessors and content/ class pass-throughs. 90 // Temporary accessors and content/ class pass-throughs.
91 // TODO(stuartmorgan): Re-evaluate this list once the refactorings have 91 // TODO(stuartmorgan): Re-evaluate this list once the refactorings have
92 // settled down. 92 // settled down.
93 CRWSessionController* GetSessionController(); 93 CRWSessionController* GetSessionController();
94 void LoadURL(const GURL& url, 94 void LoadURL(const GURL& url,
95 const Referrer& referrer, 95 const Referrer& referrer,
96 ui::PageTransition type); 96 ui::PageTransition type);
97 97
98 // Adds a transient item with the given URL. A transient item will be
99 // discarded on any navigation.
100 void AddTransientItem(const GURL& url);
Eugene But (OOO till 7-30) 2017/03/30 23:01:49 Please add tests for this new method
liaoyuke 2017/03/31 15:50:12 Thank you for catching this!
101
98 // Adds a new item with the given url, referrer, navigation type, and 102 // Adds a new item with the given url, referrer, navigation type, and
99 // initiation type, making it the pending item. If pending item is the same as 103 // initiation type, making it the pending item. If pending item is the same as
100 // the current item, this does nothing. |referrer| may be nil if there isn't 104 // the current item, this does nothing. |referrer| may be nil if there isn't
101 // one. The item starts out as pending, and will be lost unless 105 // one. The item starts out as pending, and will be lost unless
102 // |-commitPendingItem| is called. 106 // |-commitPendingItem| is called.
103 void AddPendingItem(const GURL& url, 107 void AddPendingItem(const GURL& url,
104 const web::Referrer& referrer, 108 const web::Referrer& referrer,
105 ui::PageTransition navigation_type, 109 ui::PageTransition navigation_type,
106 NavigationInitiationType initiation_type); 110 NavigationInitiationType initiation_type);
107 111
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 // List of transient url rewriters added by |AddTransientURLRewriter()|. 196 // List of transient url rewriters added by |AddTransientURLRewriter()|.
193 std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>> 197 std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>>
194 transient_url_rewriters_; 198 transient_url_rewriters_;
195 199
196 DISALLOW_COPY_AND_ASSIGN(NavigationManagerImpl); 200 DISALLOW_COPY_AND_ASSIGN(NavigationManagerImpl);
197 }; 201 };
198 202
199 } // namespace web 203 } // namespace web
200 204
201 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 205 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698