Set user agent type of transient item the same as pending item.

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 1077 matching lines @@
 
   auto* helper = FindTabHelper::FromWebState(tab.webState);
   return (helper && helper->CurrentPageSupportsFindInPage() &&
           !helper->IsFindUIActive());
 }
 
 - (web::UserAgentType)userAgentType {
   web::WebState* webState = [_model currentTab].webState;
   if (!webState)
     return web::UserAgentType::NONE;
-  web::NavigationItem* visibleItem =
-      webState->GetNavigationManager()->GetVisibleItem();
-  if (!visibleItem)
+
+  web::NavigationItem* item = nullptr;

[Eugene But (OOO till 7-30), 2017/03/30 23:01:49]

ditto

[liaoyuke, 2017/03/31 15:50:12]

Done.

+  if (webState->GetNavigationManager()->GetTransientItem())
+    item = webState->GetNavigationManager()->GetTransientItem();
+  else if (webState->GetNavigationManager()->GetPendingItem())
+    item = webState->GetNavigationManager()->GetPendingItem();
+  else if (webState->GetNavigationManager()->GetLastCommittedItem())
+    item = webState->GetNavigationManager()->GetLastCommittedItem();

[Eugene But (OOO till 7-30), 2017/03/30 23:01:49]

Copying this logic everywhere is quite error prone. This is ok for a temporary
solution, but then we need a plan for maintainable permanent implementation

[liaoyuke, 2017/03/31 15:50:12]

Acknowledged.

+
+  if (!item)
     return web::UserAgentType::NONE;
 
-  return visibleItem->GetUserAgentType();
+  return item->GetUserAgentType();
 }
 
 - (void)setVisible:(BOOL)visible {
   if (_visible == visible)
     return;
   _visible = visible;
 }
 
 - (void)setViewVisible:(BOOL)viewVisible {
   if (_viewVisible == viewVisible)
@@ skipping 4012 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end