Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: ios/shared/chrome/browser/ui/commands/command_dispatcher.mm

Issue 2779213003: [clean] Use CommandDispatcher to show/close Settings. (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/shared/chrome/browser/ui/commands/command_dispatcher.mm
diff --git a/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm b/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm
index 4829b3be6edab567d6bf400b4d5cd674c981149c..a3c12f8e54835ddbcb1a41b0c2e503e6d0772809 100644
--- a/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm
+++ b/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm
@@ -25,6 +25,10 @@
_forwardingTargets[selector] = target;
}
+- (void)stopDispatchingForSelector:(SEL)selector {
+ _forwardingTargets.erase(selector);
+}
+
// |-stopDispatchingToTarget| should be called much less often than
// |-forwardingTargetForSelector|, so removal is intentionally O(n) in order
// to prioritize the speed of lookups.
@@ -37,7 +41,7 @@
}
for (auto* selector : selectorsToErase) {
- _forwardingTargets.erase(selector);
+ [self stopDispatchingForSelector:selector];
}
}

Powered by Google App Engine
This is Rietveld 408576698