Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Issue 2779213003: [clean] Use CommandDispatcher to show/close Settings. (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
index 945ed8931fdde03f828233b29d034056fcca5fb5..d4a73a05af6b47f07630e6ec28f513dce1e9c805 100644
--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
@@ -18,6 +18,7 @@
#import "ios/shared/chrome/browser/coordinator_context/coordinator_context.h"
#import "ios/shared/chrome/browser/tabs/web_state_list.h"
#import "ios/shared/chrome/browser/ui/browser_list/browser.h"
+#import "ios/shared/chrome/browser/ui/commands/command_dispatcher.h"
#import "ios/shared/chrome/browser/ui/coordinators/browser_coordinator+internal.h"
#import "ios/web/public/navigation_manager.h"
#include "ios/web/public/web_state/web_state.h"
@@ -123,14 +124,18 @@
#pragma mark - SettingsCommands
- (void)showSettings {
+ CommandDispatcher* dispatcher = self.browser->dispatcher();
+ [dispatcher startDispatchingToTarget:self
+ forSelector:@selector(closeSettings)];
SettingsCoordinator* settingsCoordinator = [[SettingsCoordinator alloc] init];
- settingsCoordinator.settingsCommandHandler = self;
[self addOverlayCoordinator:settingsCoordinator];
self.settingsCoordinator = settingsCoordinator;
[settingsCoordinator start];
}
- (void)closeSettings {
+ CommandDispatcher* dispatcher = self.browser->dispatcher();
+ [dispatcher stopDispatchingForSelector:@selector(closeSettings)];
[self.settingsCoordinator stop];
[self.settingsCoordinator.parentCoordinator
removeChildCoordinator:self.settingsCoordinator];
« no previous file with comments | « ios/clean/chrome/browser/ui/tab_grid/BUILD.gn ('k') | ios/shared/chrome/browser/ui/commands/command_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698