ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm - Issue 2779213003: [clean] Use CommandDispatcher to show/close Settings.

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Issue 2779213003: [clean] Use CommandDispatcher to show/close Settings. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

index 945ed8931fdde03f828233b29d034056fcca5fb5..29df98d5f449ac683f3534320c91c34703094163 100644

--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

@@ -18,6 +18,7 @@

#import "ios/shared/chrome/browser/coordinator_context/coordinator_context.h"

#import "ios/shared/chrome/browser/tabs/web_state_list.h"

#import "ios/shared/chrome/browser/ui/browser_list/browser.h"

+#import "ios/shared/chrome/browser/ui/commands/command_dispatcher.h"

#import "ios/shared/chrome/browser/ui/coordinators/browser_coordinator+internal.h"

#import "ios/web/public/navigation_manager.h"

#include "ios/web/public/web_state/web_state.h"

@@ -123,14 +124,18 @@

#pragma mark - SettingsCommands

- (void)showSettings {

+ CommandDispatcher* dispatcher = self.browser->dispatcher();

+ [dispatcher startDispatchingToTarget:self

+ forSelector:@selector(closeSettings)];

SettingsCoordinator* settingsCoordinator = [[SettingsCoordinator alloc] init];

- settingsCoordinator.settingsCommandHandler = self;

[self addOverlayCoordinator:settingsCoordinator];

self.settingsCoordinator = settingsCoordinator;

[settingsCoordinator start];

}

- (void)closeSettings {

+ CommandDispatcher* dispatcher = self.browser->dispatcher();

+ [dispatcher stopDispatchingToTarget:self];

lpromero 2017/03/29 17:48:46 This will be problematic if this controller starts

marq (ping after 24h) 2017/03/30 07:53:33 Yes, or maybe (also?) -stopDispatchingToTarget:for

lpromero 2017/03/30 11:45:26 Done for the individual method. I don't pass the t

[self.settingsCoordinator stop];

[self.settingsCoordinator.parentCoordinator

removeChildCoordinator:self.settingsCoordinator];

« no previous file with comments | « ios/clean/chrome/browser/ui/settings/settings_coordinator.mm ('k') | no next file » | no next file with comments »