[clean] Use CommandDispatcher to show/close Settings.

ios/shared/chrome/browser/ui/commands/command_dispatcher_unittest.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/shared/chrome/browser/ui/commands/command_dispatcher.h"
 
 #import <Foundation/Foundation.h>
 
 #include "base/macros.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 142 matching lines @@
   NSObject* object_argument = [[NSObject alloc] init];
   [dispatcher methodWithObject:object_argument];
   EXPECT_FALSE(target.intMethodCalled);
   EXPECT_TRUE(target.objectMethodCalled);
   EXPECT_EQ(object_argument, target.objectArgument);
 
   [target resetProperties];
   EXPECT_EQ(13, [dispatcher methodToAddFirstArgument:7 toSecond:6]);
   EXPECT_FALSE(target.intMethodCalled);
   EXPECT_FALSE(target.objectMethodCalled);
-  EXPECT_EQ(42, [dispatcher methodToAddFirstArgument:34 toSecond:8]);
 }
 
 // Tests that messages are routed to the proper handler when multiple targets
 // are registered.
 TEST(CommandDispatcherTest, MultipleTargets) {
   id dispatcher = [[CommandDispatcher alloc] init];
   CommandDispatcherTestSimpleTarget* showTarget =
       [[CommandDispatcherTestSimpleTarget alloc] init];
   CommandDispatcherTestSimpleTarget* hideTarget =
       [[CommandDispatcherTestSimpleTarget alloc] init];
 
   [dispatcher startDispatchingToTarget:showTarget forSelector:@selector(show)];
   [dispatcher startDispatchingToTarget:hideTarget forSelector:@selector(hide)];
 
   [dispatcher show];
   EXPECT_TRUE(showTarget.showCalled);
   EXPECT_FALSE(hideTarget.showCalled);
 
   [showTarget resetProperties];
   [dispatcher hide];
   EXPECT_FALSE(showTarget.hideCalled);
   EXPECT_TRUE(hideTarget.hideCalled);
 }
 
-// Tests that handlers are no longer forwarded messages after deregistration.
-TEST(CommandDispatcherTest, Deregistration) {
+// Tests that handlers are no longer forwarded messages after selector
+// deregistration.
+TEST(CommandDispatcherTest, SelectorDeregistration) {
+  id dispatcher = [[CommandDispatcher alloc] init];
+  CommandDispatcherTestSimpleTarget* target =
+      [[CommandDispatcherTestSimpleTarget alloc] init];
+
+  [dispatcher startDispatchingToTarget:target forSelector:@selector(show)];
+  [dispatcher startDispatchingToTarget:target forSelector:@selector(hide)];
+
+  [dispatcher show];
+  EXPECT_TRUE(target.showCalled);
+  EXPECT_FALSE(target.hideCalled);
+
+  [target resetProperties];
+  [dispatcher stopDispatchingForSelector:@selector(show)];
+  bool exception_caught = false;
+  @try {
+    [dispatcher show];
+  } @catch (NSException* exception) {
+    EXPECT_EQ(NSInvalidArgumentException, [exception name]);
+    exception_caught = true;
+  }
+  EXPECT_TRUE(exception_caught);
+
+  [dispatcher hide];
+  EXPECT_FALSE(target.showCalled);
+  EXPECT_TRUE(target.hideCalled);
+}
+
+// Tests that handlers are no longer forwarded messages after target
+// deregistration.
+TEST(CommandDispatcherTest, TargetDeregistration) {
   id dispatcher = [[CommandDispatcher alloc] init];
   CommandDispatcherTestSimpleTarget* showTarget =
       [[CommandDispatcherTestSimpleTarget alloc] init];
   CommandDispatcherTestSimpleTarget* hideTarget =
       [[CommandDispatcherTestSimpleTarget alloc] init];
 
   [dispatcher startDispatchingToTarget:showTarget forSelector:@selector(show)];
   [dispatcher startDispatchingToTarget:hideTarget forSelector:@selector(hide)];
 
   [dispatcher show];
@@ skipping 27 matching lines @@
   bool exception_caught = false;
   @try {
     [dispatcher hide];
   } @catch (NSException* exception) {
     EXPECT_EQ(NSInvalidArgumentException, [exception name]);
     exception_caught = true;
   }
 
   EXPECT_TRUE(exception_caught);
 }