Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
Side by Side Diff: third_party/googletest/OWNERS
Issue
2779193002
:
Roll googletest to 1.8.0. (Closed)
Patch Set: Fix build errors.
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
DEPS
base/gtest_prod_util.h
build/secondary/testing/gmock/BUILD.gn
build/secondary/testing/gtest/BUILD.gn
device/bluetooth/dbus/fake_bluetooth_media_endpoint_service_provider.h
net/socket/sequenced_socket_data_unittest.cc
testing/gmock/BUILD.gn
testing/gmock/include/gmock/gmock.h
testing/gmock/include/gmock/gmock-actions.h
testing/gmock/include/gmock/gmock-generated-function-mockers.h
testing/gmock/include/gmock/gmock-matchers.h
testing/gmock_custom/gmock/internal/custom/gmock-port.h
testing/gtest/BUILD.gn
testing/gtest/include/gtest/gtest.h
testing/gtest/include/gtest/gtest-death-test.h
testing/gtest/include/gtest/gtest-message.h
testing/gtest/include/gtest/gtest-param-test.h
testing/gtest/include/gtest/gtest-spi.h
testing/gtest/include/gtest/gtest_prod.h
testing/gtest_mac.h
testing/gtest_mac.mm
testing/gtest_mac_unittest.mm
third_party/.gitignore
third_party/googletest/BUILD.gn
third_party/googletest/OWNERS
third_party/googletest/README.chromium
third_party/googletest/gmock_custom/gmock/internal/custom/gmock-port.h
View unified diff
|
« third_party/googletest/BUILD.gn
('K') |
« third_party/googletest/BUILD.gn
('k') |
third_party/googletest/README.chromium »
('j') |
third_party/googletest/README.chromium »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
phajdan.jr@chromium.org
Nico
2017/04/26 20:46:19
please add you and me
please add you and me
pwnall
2017/04/26 22:38:24
Done. I'm not sure about the ordering. I borrowed
Show quoted text
On 2017/04/26 20:46:19, Nico wrote: > please add you and me
Done. I'm not sure about the ordering. I borrowed the original list from testing/OWNERS. Does this look reasonable?
2
dpranke@chromium.org
OLD
NEW
« third_party/googletest/BUILD.gn
('K') |
« third_party/googletest/BUILD.gn
('k') |
third_party/googletest/README.chromium »
('j') |
third_party/googletest/README.chromium »
('J')
Issue 2779193002: Roll googletest to 1.8.0. (Closed)
Created 3 years, 8 months ago by pwnall
Modified 3 years, 7 months ago
Reviewers: Nico, Dirk Pranke, agl, rkc, skobes
Base URL:
Comments: 16