| OLD | NEW |
|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # | 2 # |
| 3 # Copyright 2012 the V8 project authors. All rights reserved. | 3 # Copyright 2012 the V8 project authors. All rights reserved. |
| 4 # Redistribution and use in source and binary forms, with or without | 4 # Redistribution and use in source and binary forms, with or without |
| 5 # modification, are permitted provided that the following conditions are | 5 # modification, are permitted provided that the following conditions are |
| 6 # met: | 6 # met: |
| 7 # | 7 # |
| 8 # * Redistributions of source code must retain the above copyright | 8 # * Redistributions of source code must retain the above copyright |
| 9 # notice, this list of conditions and the following disclaimer. | 9 # notice, this list of conditions and the following disclaimer. |
| 10 # * Redistributions in binary form must reproduce the above | 10 # * Redistributions in binary form must reproduce the above |
| (...skipping 30 matching lines...) Expand all Loading... |
| 41 import pickle | 41 import pickle |
| 42 import re | 42 import re |
| 43 import sys | 43 import sys |
| 44 import subprocess | 44 import subprocess |
| 45 import multiprocessing | 45 import multiprocessing |
| 46 from subprocess import PIPE | 46 from subprocess import PIPE |
| 47 | 47 |
| 48 # Disabled LINT rules and reason. | 48 # Disabled LINT rules and reason. |
| 49 # build/include_what_you_use: Started giving false positives for variables | 49 # build/include_what_you_use: Started giving false positives for variables |
| 50 # named "string" and "map" assuming that you needed to include STL headers. | 50 # named "string" and "map" assuming that you needed to include STL headers. |
| 51 # runtime/references: Started giving a lot of positives after depot-tools |
| 52 # update. To be fixed soon: v8:3326. |
| 51 | 53 |
| 52 ENABLED_LINT_RULES = """ | 54 ENABLED_LINT_RULES = """ |
| 53 build/class | 55 build/class |
| 54 build/deprecated | 56 build/deprecated |
| 55 build/endif_comment | 57 build/endif_comment |
| 56 build/forward_decl | 58 build/forward_decl |
| 57 build/include_order | 59 build/include_order |
| 58 build/printf_format | 60 build/printf_format |
| 59 build/storage_class | 61 build/storage_class |
| 60 legal/copyright | 62 legal/copyright |
| (...skipping 12 matching lines...) Expand all Loading... |
| 73 runtime/arrays | 75 runtime/arrays |
| 74 runtime/casting | 76 runtime/casting |
| 75 runtime/deprecated_fn | 77 runtime/deprecated_fn |
| 76 runtime/explicit | 78 runtime/explicit |
| 77 runtime/int | 79 runtime/int |
| 78 runtime/memset | 80 runtime/memset |
| 79 runtime/mutex | 81 runtime/mutex |
| 80 runtime/nonconf | 82 runtime/nonconf |
| 81 runtime/printf | 83 runtime/printf |
| 82 runtime/printf_format | 84 runtime/printf_format |
| 83 runtime/references | |
| 84 runtime/rtti | 85 runtime/rtti |
| 85 runtime/sizeof | 86 runtime/sizeof |
| 86 runtime/string | 87 runtime/string |
| 87 runtime/virtual | 88 runtime/virtual |
| 88 runtime/vlog | 89 runtime/vlog |
| 89 whitespace/blank_line | 90 whitespace/blank_line |
| 90 whitespace/braces | 91 whitespace/braces |
| 91 whitespace/comma | 92 whitespace/comma |
| 92 whitespace/comments | 93 whitespace/comments |
| 93 whitespace/ending_newline | 94 whitespace/ending_newline |
| (...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 434 "two empty lines between declarations check..." | 435 "two empty lines between declarations check..." |
| 435 success = SourceProcessor().Run(workspace) and success | 436 success = SourceProcessor().Run(workspace) and success |
| 436 if success: | 437 if success: |
| 437 return 0 | 438 return 0 |
| 438 else: | 439 else: |
| 439 return 1 | 440 return 1 |
| 440 | 441 |
| 441 | 442 |
| 442 if __name__ == '__main__': | 443 if __name__ == '__main__': |
| 443 sys.exit(Main()) | 444 sys.exit(Main()) |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 277913002:
Presubmit checks recover. (Closed)
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge