Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2779063002: One more minor mixin fix (Closed)

Created:
3 years, 8 months ago by vsm
Modified:
3 years, 7 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

One more minor mixin fix We need to preserve the Mixin constructor to make sure metadata (e.g., implements) is injected in the right place. R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/92d39a4e0819adf4fed9c69fe9886884e753c449

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix for callable constructors #

Patch Set 3 : Fix comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 2 3 chunks +11 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
vsm
3 years, 8 months ago (2017-03-28 15:07:31 UTC) #3
Jennifer Messerly
lgtm but a suggestion https://codereview.chromium.org/2779063002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart (right): https://codereview.chromium.org/2779063002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart#newcode38 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:38: $copyProperties(Mixin.prototype, m.prototype); hmm, maybe just ...
3 years, 8 months ago (2017-03-28 20:47:48 UTC) #4
vsm
3 years, 7 months ago (2017-05-18 23:58:29 UTC) #6
vsm
3 years, 7 months ago (2017-05-18 23:58:31 UTC) #7
vsm
3 years, 7 months ago (2017-05-19 14:27:49 UTC) #9
Jacob
lgtm https://codereview.chromium.org/2779063002/diff/20001/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart (right): https://codereview.chromium.org/2779063002/diff/20001/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart#newcode35 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:35: var constructor = Mixin.prototype.constructor; nit: let
3 years, 7 months ago (2017-05-19 14:31:27 UTC) #10
vsm
3 years, 7 months ago (2017-05-19 14:41:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
92d39a4e0819adf4fed9c69fe9886884e753c449 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698