[Android] Focus/Blur contents when window focus changes

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 4f54ff25e4455c47fa5d73073115f644e5a12b0f..fb0c0bd9df5e93de6f7e263ed412e40308daf709 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1335,7 +1335,12 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
      */
     public void onWindowFocusChanged(boolean hasWindowFocus) {
         mImeAdapter.onWindowFocusChanged(hasWindowFocus);
-        if (!hasWindowFocus) resetGestureDetection();
+        if (!hasWindowFocus) {
+            resetGestureDetection();
+            if (hasFocus()) onFocusChanged(false, true /* hideKeyboardOnBlur */);

[aelias_OOO_until_Jul13, 2017/03/29 21:54:04]

This is stacking the effects of the view focus and window focus booleans in a
way that's hard to reason about.  I suggest changing
ContentViewCore.onFocusChanged to not take the first boolean argument, and
instead directly within itself call the view and window focus methods to
determine the new focus status.

Please also add an early-return at the top of ContentViewCore.onFocusChanged if
focus did not wind up changing, which probably should involve a boolean which is
also set correctly at ContentViewCore construction.

[mthiesse, 2017/03/30 00:49:26]

Done.

+        } else {
+            if (hasFocus()) onFocusChanged(true, true /* hideKeyboardOnBlur */);
+        }

[Changwan Ryu, 2017/03/30 00:05:49]

Because ImeAdapter and SelectionPopupController already handle window and view
focus changes separately, could we refactor this into something like the
following?

public void onWindowFocusChanged(boolean hasWindowFocus) {
    ...
    onFocusChangeInternal();
}

public void onFocusChanged(boolean gainFocus, boolean hideKeyboardOnBlur) {
    ...
    onFocusChangeInternal();
}

private void onFocusChangeInternal() {
    boolean focused = hasWindowFocus() && hasFocus();
    if (focused != mFocused) {
        if (mNativeContentViewCore != 0) { 
            nativeSetFocus(mNativeContentViewCore, hasWindowFocus() &&
hasFocus());
        }
        mFocused = focused;
    }
}

I think this should be enough for now.

Otherwise, at least ThreadedInputConnectionFactory's logging will be messed up.

BTW, as aelias@ pointed out, window and view focus change order can be quite
complex and hard to predict. In the case of web app, the normal order would be
window focus loss --> view focus loss, but some webview app may change view
focus in the middle of window focus loss which will end up as view focus loss
--> window focus loss.

[mthiesse, 2017/03/30 00:12:45]

Thanks, that's essentially what I'm writing now.

However, I'm bashing my head against a wall because View#hasWindowFocus()
returns false when we first get a ContainerView, but then OnWindowFocusChanged
is *never* called until the app first loses window focus.

I'm trying to find some other way of setting the initial state correctly, but it
seems that View#hasWindowFocus() really can't be trusted.

[mthiesse, 2017/03/30 00:49:26]

Done.

         mSelectionPopupController.onWindowFocusChanged(hasWindowFocus);
         for (mGestureStateListenersIterator.rewind(); mGestureStateListenersIterator.hasNext();) {
             mGestureStateListenersIterator.next().onWindowFocusChanged(hasWindowFocus);