Don't disable downward inference inside initializers used for top-level inference.

Don't disable downward inference inside initializers used for top-level inference.

So, I'm removing this flag that didn't allow us to perform invocation
type inference and caused bogus STRONG_MODE_INVALID_CAST_NEW_EXPR errors.

This causes us to perform inference where we don't need it, and report
(only informational?) info:INFERRED_TYPE_ALLOCATION for these invocations.
At the same point, we report errors for these cases, which should be
fixed anyway, and then downward inference will not be performed anymore.

R=brianwilkerson@google.com, leafp@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/16e7ab8d1795105a08aff9fe1c3663ed5e2240ad

[Brian Wilkerson, 2017-03-29 13:33:54]

lgtm

[scheglov, 2017-03-29 16:24:03]

Description was changed from

==========
Don't disable downward inference inside initializers used for top-level
inference.

So, I'm removing this flag that didn't allow us to perform invocation
type inference and caused bogus STRONG_MODE_INVALID_CAST_NEW_EXPR errors.

This causes us to perform inference where we don't need it, and report
(only informational?) info:INFERRED_TYPE_ALLOCATION for these invocations.
At the same point, we report errors for these cases, which should be
fixed anyway, and then downward inference will not be performed anymore.

R=brianwilkerson@google.com, leafp@google.com
BUG=
==========

to

==========
Don't disable downward inference inside initializers used for top-level
inference.

So, I'm removing this flag that didn't allow us to perform invocation
type inference and caused bogus STRONG_MODE_INVALID_CAST_NEW_EXPR errors.

This causes us to perform inference where we don't need it, and report
(only informational?) info:INFERRED_TYPE_ALLOCATION for these invocations.
At the same point, we report errors for these cases, which should be
fixed anyway, and then downward inference will not be performed anymore.

R=brianwilkerson@google.com, leafp@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/16e7ab8d1795105a08aff9fe1c3663ed5e2240ad
==========

[scheglov, 2017-03-29 16:24:05]

Committed patchset #1 (id:1) manually as
16e7ab8d1795105a08aff9fe1c3663ed5e2240ad (presubmit successful).

[Leaf, 2017-03-29 17:49:56]

lgtm