Move collection of native classes from NativeEnqueuerBase to NativeResolutionEnqueuer

Move collection of native classes from NativeEnqueuerBase to NativeResolutionEnqueuer

The collected classes were needlessly recomputed in NativeCodegenEnqueuer. Now the set of classes is computed once and copied from NativeResolutionEnqueuer to NativeCodegenEnqueuer.

Next step is to move the collection from NativeResolutionEnqueuer to NativeDataResolver since its computation is AST dependent.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/a905b19f5dc5c701209fc914231f41f5578a0d15

[Johnni Winther, 2017-03-28 09:30:28]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Johnni Winther, 2017-03-28 09:30:28]

https://codereview.chromium.org/2779003002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/2779003002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:50: abstract class NativeEnqueuerBase
implements NativeEnqueuer {
Weird diff. Code is moved from NativeEnqueuerBase to NativeResolutionEnqueuer
but it looks like the opposite.

[Emily Fortuna, 2017-03-28 18:10:30]

lgtm
I'll trust you on the diff comment. O.o

[Johnni Winther, 2017-03-29 08:43:23]

Description was changed from

==========
Move collection of native classes from NativeEnqueuerBase to
NativeResolutionEnqueuer

The collected classes were needlessly recomputed in NativeCodegenEnqueuer. Now
the set of classes is computed once and copied from NativeResolutionEnqueuer to
NativeCodegenEnqueuer.

Next step is to move the collection from NativeResolutionEnqueuer to
NativeDataResolver since its computation is AST dependent.
==========

to

==========
Move collection of native classes from NativeEnqueuerBase to
NativeResolutionEnqueuer

The collected classes were needlessly recomputed in NativeCodegenEnqueuer. Now
the set of classes is computed once and copied from NativeResolutionEnqueuer to
NativeCodegenEnqueuer.

Next step is to move the collection from NativeResolutionEnqueuer to
NativeDataResolver since its computation is AST dependent.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a905b19f5dc5c701209fc914231f41f5578a0d15
==========

[Johnni Winther, 2017-03-29 08:43:25]

Committed patchset #1 (id:1) manually as
a905b19f5dc5c701209fc914231f41f5578a0d15 (presubmit successful).