Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

Issue 2778983006: Make /deep/ as no-op and remove ::shadow in dynamic profile (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
index df48a8857ffeb417af21c52c59f72f23d4df8a2d..729f3c9cc010bed0ef9cd4ffa5d1a36ae985d450 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
@@ -442,7 +442,7 @@ std::unique_ptr<CSSParserSelector> CSSSelectorParser::ConsumePseudo(
AtomicString value = token.Value().ToAtomicString().LowerASCII();
bool has_arguments = token.GetType() == kFunctionToken;
- selector->UpdatePseudoType(value, has_arguments);
+ selector->UpdatePseudoType(value, *context_, has_arguments);
if (!RuntimeEnabledFeatures::cssSelectorsFocusWithinEnabled() &&
selector->GetPseudoType() == CSSSelector::kPseudoFocusWithin)
@@ -582,7 +582,8 @@ CSSSelector::RelationType CSSSelectorParser::ConsumeCombinator(
const CSSParserToken& slash = range.ConsumeIncludingWhitespace();
if (slash.GetType() != kDelimiterToken || slash.Delimiter() != '/')
failed_parsing_ = true;
- return CSSSelector::kShadowDeep;
+ return context_->IsDynamicProfile() ? CSSSelector::kShadowDeepAsDescendant
+ : CSSSelector::kShadowDeep;
}
default:
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserSelector.h ('k') | third_party/WebKit/Source/core/dom/StyleEngineTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698