Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4502)

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.h
diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h
index 7b9a5d936d14055a368380a74ae84d31b0631363..35c005d1af69eefa392635567bbcf358f053b12c 100644
--- a/chrome/browser/engagement/site_engagement_service.h
+++ b/chrome/browser/engagement/site_engagement_service.h
@@ -26,6 +26,11 @@ namespace base {
class Clock;
}
+namespace banners {
+FORWARD_DECLARE_TEST(AppBannerManagerBrowserTest,
+ CheckOnLoadWithoutSufficientEngagement);
+}
+
namespace content {
class WebContents;
}
@@ -173,6 +178,8 @@ class SiteEngagementService : public KeyedService,
FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,
IncognitoEngagementService);
FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetScoreFromSettings);
+ FRIEND_TEST_ALL_PREFIXES(banners::AppBannerManagerBrowserTest,
+ CheckOnLoadWithoutSufficientEngagement);
FRIEND_TEST_ALL_PREFIXES(AppBannerSettingsHelperTest, SiteEngagementTrigger);
#if defined(OS_ANDROID)
« no previous file with comments | « chrome/browser/banners/app_banner_manager_browsertest.cc ('k') | chrome/browser/installable/installable_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698