Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager_android.h
diff --git a/chrome/browser/android/banners/app_banner_manager_android.h b/chrome/browser/android/banners/app_banner_manager_android.h
index 4fcdeeff7b1e76fbd214f709d003a95301a9753f..8eaddb47ad5d35bbe081a3b23d6864b09036344c 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.h
+++ b/chrome/browser/android/banners/app_banner_manager_android.h
@@ -39,10 +39,21 @@ class AppBannerManagerAndroid
const base::android::ScopedJavaGlobalRef<jobject>& GetJavaBannerManager()
const;
- // Returns true if this object is currently active.
+ // Returns true if the banner pipeline is currently running.
bool IsActiveForTesting(JNIEnv* env,
const base::android::JavaParamRef<jobject>& jobj);
+ // Informs the InstallableManager for the WebContents we are attached to that
+ // the add to homescreen menu item has been tapped.
+ void RecordMenuItemAddToHomescreen(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& jobj);
+
+ // Informs the InstallableManager for the WebContents we are attached to that
+ // the menu has been opened.
+ void RecordMenuOpen(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& jobj);
+
// Called when the Java-side has retrieved information for the app.
// Returns |false| if an icon fetch couldn't be kicked off.
bool OnAppDetailsRetrieved(
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698