Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1823)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 2d2cfe58bec3ce0c221942beceb73a9df766b0a3..f7849b73c09e5908207e07b9c202ee851c838711 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -21,6 +21,7 @@ import android.widget.Button;
import android.widget.TextView;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ShortcutHelper;
@@ -536,6 +537,23 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@Feature({"AppBanners"})
public void testWebAppBannerAppears() throws Exception {
triggerWebAppBanner(mWebAppUrl, WEB_APP_TITLE, false);
+
+ // Verify metrics calling in the successful case.
+ ThreadUtils.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
+ manager.recordMenuItemAddToHomescreen();
+ assertEquals(1,
+ RecordHistogram.getHistogramValueCountForTesting(
+ "Webapp.InstallabilityCheckStatus.MenuItemAddToHomescreen", 5));
+
+ manager.recordMenuOpen();
+ assertEquals(1,
+ RecordHistogram.getHistogramValueCountForTesting(
+ "Webapp.InstallabilityCheckStatus.MenuOpen", 5));
+ }
+ });
}
@SmallTest

Powered by Google App Engine
This is Rietveld 408576698