Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4276)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index babe917ae2a35f21a9b1fd192dcb2d476f45d596..ce221b5561e76c651242feec419c73bbaedf1cdb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -160,6 +160,16 @@ public class AppBannerManager {
return nativeIsActiveForTesting(mNativePointer);
}
+ /** Signal to native that the add to homescreen menu item was tapped for metrics purposes. */
+ public void recordMenuItemAddToHomescreen() {
+ nativeRecordMenuItemAddToHomescreen(mNativePointer);
+ }
+
+ /** Signal to native that the menu was opened for metrics purposes. */
+ public void recordMenuOpen() {
+ nativeRecordMenuOpen(mNativePointer);
+ }
+
/** Sets constants (in days) the banner should be blocked for after dismissing and ignoring. */
@VisibleForTesting
static void setDaysAfterDismissAndIgnoreForTesting(int dismissDays, int ignoreDays) {
@@ -184,6 +194,8 @@ public class AppBannerManager {
}
private static native int nativeGetHomescreenLanguageOption();
+ private native void nativeRecordMenuItemAddToHomescreen(long nativeAppBannerManagerAndroid);
+ private native void nativeRecordMenuOpen(long nativeAppBannerManagerAndroid);
private static native AppBannerManager nativeGetJavaBannerManagerForWebContents(
WebContents webContents);
private native boolean nativeOnAppDetailsRetrieved(long nativeAppBannerManagerAndroid,

Powered by Google App Engine
This is Rietveld 408576698