Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Fix enum in test + minor improvements Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e09546cdb00a1f6f48699f642b00101ae3b64535..4c51b79c19ec83d6a5cb7dcbcdc97d449a9d9491 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -76819,6 +76819,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Webapp.InstallabilityCheckStatus.MenuItemAddToHomescreen"
+ enum="InstallabilityCheckStatus">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ Records whether or not the installability check has completed when the user
+ taps the add to homescreen menu item on Android.
+ </summary>
+</histogram>
+
+<histogram name="Webapp.InstallabilityCheckStatus.MenuOpen"
+ enum="InstallabilityCheckStatus">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ Records whether or not the installability check has completed when the user
+ opens the menu on Android.
+ </summary>
+</histogram>
+
<histogram name="Webapp.Splashscreen.BackgroundColor"
enum="SplashscreenColorStatus">
<owner>mlamouri@chromium.org</owner>
@@ -98262,6 +98280,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="35" label="Ran by google.com/intl/ (deprecated)"/>
</enum>
+<enum name="InstallabilityCheckStatus" type="int">
+ <int value="0" label="Check not started"/>
+ <int value="1" label="Check terminated before it could finish"/>
+ <int value="2" label="Check not complete for a non-PWA"/>
+ <int value="3" label="Check not complete for a PWA"/>
+ <int value="4" label="Check complete for a non-PWA"/>
+ <int value="5" label="Check complete for a PWA"/>
Ilya Sherman 2017/03/31 17:03:16 nit: Here too, "PWA" is not entirely obvious. You
dominickn 2017/04/03 00:06:46 Done, mentioned it in the histogram description.
+</enum>
+
<enum name="InstallStatus" type="int">
<int value="0" label="FIRST_INSTALL_SUCCESS"/>
<int value="1" label="INSTALL_REPAIRED"/>
« chrome/browser/installable/installable_metrics.cc ('K') | « chrome/common/chrome_features.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698