chrome/browser/installable/installable_metrics.h - Issue 2778983005: Allow the app banner installability check to run on page load.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/installable/installable_metrics.h

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)

Patch Set: Fix enum in test + minor improvements Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/installable/installable_manager.cc ('K') | « chrome/browser/installable/installable_manager_browsertest.cc ('k') | chrome/browser/installable/installable_metrics.cc » ('j') | chrome/browser/installable/installable_metrics.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_METRICS_H_

	6 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_METRICS_H_

	7

	8 class InstallableMetrics {

	9 public:

	10 // This enum backs a UMA histogram and must be treated as append-only.

	11 enum InstallabilityCheckStatus {
	Ilya Sherman 2017/03/31 17:03:15 Optional nit: You can now use "enum class" without Optional nit: You can now use "enum class" without casts for recording UMA histograms, so you might want to go ahead and do that here. dominickn 2017/04/03 00:06:46 Done. zomg no more static casting!!!!! Show quoted text On 2017/03/31 17:03:15, Ilya Sherman wrote: > Optional nit: You can now use "enum class" without casts for recording UMA > histograms, so you might want to go ahead and do that here. Done. zomg no more static casting!!!!!
	12 NOT_STARTED,

	13 STOPPED_BEFORE_COMPLETION,

	14 IN_PROGRESS_NON_PWA,
	Ilya Sherman 2017/03/31 17:03:15 nit: "PWA" is not an obvious acronym, at least for nit: "PWA" is not an obvious acronym, at least for me. I'd encourage you to spell out something more complete here. dominickn 2017/04/03 00:06:46 Done. Show quoted text On 2017/03/31 17:03:15, Ilya Sherman wrote: > nit: "PWA" is not an obvious acronym, at least for me. I'd encourage you to > spell out something more complete here. Done.
	15 IN_PROGRESS_PWA,

	16 COMPLETE_NON_PWA,

	17 COMPLETE_PWA,

	18 MAX,
	Ilya Sherman 2017/03/31 17:03:16 Optional nit: I would name this "COUNT" -- "MAX" i Optional nit: I would name this "COUNT" -- "MAX" is usually used to semantically refer to a value that's equal to the last "real" value in the enum. dominickn 2017/04/03 00:06:46 Done. Show quoted text On 2017/03/31 17:03:16, Ilya Sherman wrote: > Optional nit: I would name this "COUNT" -- "MAX" is usually used to semantically > refer to a value that's equal to the last "real" value in the enum. Done.
	19 };

	20

	21 static void RecordMenuOpenHistogram(InstallabilityCheckStatus status);

	22 static void RecordMenuItemAddToHomescreenHistogram(

	23 InstallabilityCheckStatus status);

	24 };

	25

	26 #endif // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_METRICS_H_

OLD	NEW