Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: chrome/browser/installable/installable_metrics.cc

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Fix enum in test + minor improvements Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/installable/installable_metrics.h"
6
7 #include "base/metrics/histogram_macros.h"
8
9 namespace {
10
11 const char kMenuOpenHistogram[] = "Webapp.InstallabilityCheckStatus.MenuOpen";
12 const char kMenuItemAddToHomescreenHistogram[] =
13 "Webapp.InstallabilityCheckStatus.MenuItemAddToHomescreen";
Ilya Sherman 2017/03/31 17:03:15 Optional nit: I would go ahead and inline these na
dominickn 2017/04/03 00:06:46 Done.
14 }
15
16 void InstallableMetrics::RecordMenuOpenHistogram(
17 InstallabilityCheckStatus status) {
18 UMA_HISTOGRAM_ENUMERATION(kMenuOpenHistogram, status,
19 InstallabilityCheckStatus::MAX);
20 }
21
22 void InstallableMetrics::RecordMenuItemAddToHomescreenHistogram(
23 InstallabilityCheckStatus status) {
24 UMA_HISTOGRAM_ENUMERATION(kMenuItemAddToHomescreenHistogram, status,
25 InstallabilityCheckStatus::MAX);
26 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698