Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: chrome/common/chrome_features.cc

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/chrome_features.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_features.h" 5 #include "chrome/common/chrome_features.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "extensions/features/features.h" 9 #include "extensions/features/features.h"
10 #include "ppapi/features/features.h" 10 #include "ppapi/features/features.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 #if defined(OS_MACOSX) 85 #if defined(OS_MACOSX)
86 // Enables or disables the browser's touch bar. 86 // Enables or disables the browser's touch bar.
87 const base::Feature kBrowserTouchBar{"BrowserTouchBar", 87 const base::Feature kBrowserTouchBar{"BrowserTouchBar",
88 base::FEATURE_ENABLED_BY_DEFAULT}; 88 base::FEATURE_ENABLED_BY_DEFAULT};
89 89
90 // Enables or disables keyboard focus for the tab strip. 90 // Enables or disables keyboard focus for the tab strip.
91 const base::Feature kTabStripKeyboardFocus{"TabStripKeyboardFocus", 91 const base::Feature kTabStripKeyboardFocus{"TabStripKeyboardFocus",
92 base::FEATURE_DISABLED_BY_DEFAULT}; 92 base::FEATURE_DISABLED_BY_DEFAULT};
93 #endif // defined(OS_MACOSX) 93 #endif // defined(OS_MACOSX)
94 94
95 // Whether to trigger app banner installability checks on page load.
96 const base::Feature kCheckInstallabilityForBannerOnLoad{
97 "CheckInstallabilityForBannerOnLoad", base::FEATURE_DISABLED_BY_DEFAULT};
98
95 #if defined(OS_WIN) 99 #if defined(OS_WIN)
96 const base::Feature kCleanupToolUI{"CleanupToolUI", 100 const base::Feature kCleanupToolUI{"CleanupToolUI",
97 base::FEATURE_DISABLED_BY_DEFAULT}; 101 base::FEATURE_DISABLED_BY_DEFAULT};
98 #endif 102 #endif
99 103
100 #if defined(OS_ANDROID) 104 #if defined(OS_ANDROID)
101 // Experiment to make Geolocation permissions in the omnibox and the default 105 // Experiment to make Geolocation permissions in the omnibox and the default
102 // search engine's search page consistent. 106 // search engine's search page consistent.
103 const base::Feature kConsistentOmniboxGeolocation{ 107 const base::Feature kConsistentOmniboxGeolocation{
104 "ConsistentOmniboxGeolocation", base::FEATURE_DISABLED_BY_DEFAULT}; 108 "ConsistentOmniboxGeolocation", base::FEATURE_DISABLED_BY_DEFAULT};
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 return base::FeatureList::IsEnabled(features::kPrefService) || 321 return base::FeatureList::IsEnabled(features::kPrefService) ||
318 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) 322 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
319 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( 323 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
320 switches::kMusConfig) == switches::kMash; 324 switches::kMusConfig) == switches::kMash;
321 #else 325 #else
322 false; 326 false;
323 #endif 327 #endif
324 } 328 }
325 329
326 } // namespace features 330 } // namespace features
OLDNEW
« no previous file with comments | « chrome/common/chrome_features.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698