Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: headless/lib/headless_browser_browsertest.cc

Issue 2778983002: Fix browser tests on Mac (Closed)
Patch Set: nit change on #if defined on DefaultSizes test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/headless_browser_browsertest.cc
diff --git a/headless/lib/headless_browser_browsertest.cc b/headless/lib/headless_browser_browsertest.cc
index 6561339d51eca2405d2c3a9a6a492d33b3668c42..52931af4ab572171d84414386a5db3452cdde53e 100644
--- a/headless/lib/headless_browser_browsertest.cc
+++ b/headless/lib/headless_browser_browsertest.cc
@@ -379,8 +379,12 @@ IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, DefaultSizes) {
->GetValue()
->GetAsInteger(&window_height));
+#if !defined(OS_MACOSX)
+ // On Mac headless does not override the screen dimensions, so they are
+ // left with the actual screen values.
EXPECT_EQ(kDefaultOptions.window_size.width(), screen_width);
EXPECT_EQ(kDefaultOptions.window_size.height(), screen_height);
+#endif // !defined(OS_MACOSX)
EXPECT_EQ(kDefaultOptions.window_size.width(), window_width);
EXPECT_EQ(kDefaultOptions.window_size.height(), window_height);
}
« no previous file with comments | « headless/lib/browser/headless_web_contents_impl.cc ('k') | headless/lib/headless_devtools_client_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698