third_party/WebKit/Source/core/editing/DOMSelection.h - Issue 2778963002: Return EphemeralRange instead of Range in DOMSelection::createRangeFromSelectionEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.h

Issue 2778963002: Return EphemeralRange instead of Range in DOMSelection::createRangeFromSelectionEditor (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/DOMSelection.h

diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.h b/third_party/WebKit/Source/core/editing/DOMSelection.h

index 6dbc02aad5b233acfe70d70c8c7cbf7ccfe7b46a..150408b91fb4de31b6737a39e32c154fda96dd8f 100644

--- a/third_party/WebKit/Source/core/editing/DOMSelection.h

+++ b/third_party/WebKit/Source/core/editing/DOMSelection.h

@@ -122,7 +122,7 @@ class CORE_EXPORT DOMSelection final : public GarbageCollected<DOMSelection>,

void addConsoleError(const String& message);

Range* primaryRangeOrNull() const;

- Range* createRangeFromSelectionEditor() const;

+ EphemeralRange createRangeFromSelectionEditor() const;

bool isSelectionOfDocument() const;

void cacheRangeIfSelectionOfDocument(Range*) const;