Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Side by Side Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 2778943003: Disable flaky WebContentsViewAuraTest.OverscrollScreenshot (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_aura.h" 5 #include "content/browser/web_contents/web_contents_view_aura.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <tuple> 8 #include <tuple>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 519
520 // Tests that the page has has a screenshot when navigation happens: 520 // Tests that the page has has a screenshot when navigation happens:
521 // - from within the page (from a JS function) 521 // - from within the page (from a JS function)
522 // - interactively, when user does an overscroll gesture 522 // - interactively, when user does an overscroll gesture
523 // - interactively, when user navigates in history without the overscroll 523 // - interactively, when user navigates in history without the overscroll
524 // gesture. 524 // gesture.
525 // Flaky on Windows (http://crbug.com/357311). Might be related to 525 // Flaky on Windows (http://crbug.com/357311). Might be related to
526 // OverscrollNavigation test. 526 // OverscrollNavigation test.
527 // Flaky on Ozone (http://crbug.com/399676). 527 // Flaky on Ozone (http://crbug.com/399676).
528 // Flaky on ChromeOS (http://crbug.com/405945). 528 // Flaky on ChromeOS (http://crbug.com/405945).
529 #if defined(OS_WIN) || defined(USE_OZONE) || defined(OS_CHROMEOS) 529 // Flaky on Linux (http://crbug.com/705599)
530 #if defined(OS_WIN) || defined(USE_OZONE) || defined(OS_CHROMEOS) || \
531 defined(OS_LINUX)
530 #define MAYBE_OverscrollScreenshot DISABLED_OverscrollScreenshot 532 #define MAYBE_OverscrollScreenshot DISABLED_OverscrollScreenshot
531 #else 533 #else
532 #define MAYBE_OverscrollScreenshot OverscrollScreenshot 534 #define MAYBE_OverscrollScreenshot OverscrollScreenshot
533 #endif 535 #endif
534 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, MAYBE_OverscrollScreenshot) { 536 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, MAYBE_OverscrollScreenshot) {
535 // Disable the test for WinXP. See http://crbug/294116. 537 // Disable the test for WinXP. See http://crbug/294116.
536 #if defined(OS_WIN) 538 #if defined(OS_WIN)
537 if (base::win::GetVersion() < base::win::VERSION_VISTA) { 539 if (base::win::GetVersion() < base::win::VERSION_VISTA) {
538 LOG(WARNING) << "Test disabled due to unknown bug on WinXP."; 540 LOG(WARNING) << "Test disabled due to unknown bug on WinXP.";
539 return; 541 return;
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
1120 details = sink->OnEventFromSource(&release); 1122 details = sink->OnEventFromSource(&release);
1121 ASSERT_FALSE(details.dispatcher_destroyed); 1123 ASSERT_FALSE(details.dispatcher_destroyed);
1122 WaitAFrame(); 1124 WaitAFrame();
1123 1125
1124 EXPECT_LT(0, tracker.num_overscroll_updates()); 1126 EXPECT_LT(0, tracker.num_overscroll_updates());
1125 EXPECT_FALSE(tracker.overscroll_completed()); 1127 EXPECT_FALSE(tracker.overscroll_completed());
1126 } 1128 }
1127 } 1129 }
1128 1130
1129 } // namespace content 1131 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698