Issue 277893003: MIPS: Fix FlooringDivByPowerOf2I.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 277893003: MIPS: Fix FlooringDivByPowerOf2I. (Closed)

Created:
6 years, 7 months ago by kilvadyb

Modified:
6 years, 7 months ago

Reviewers:
Paul Lind, dusmil, danno, kisg, palfia, m.m.capewell

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Fix FlooringDivByPowerOf2I. Port r21313 (3b4cb0b) Original commit message: Fix for divisor=1, found during code inspection. We can't hit this bug, due to HDiv::Canonicalize() discarding the operation, but it might avoid a future bug hunt. Patch also includes a small tidying of the ARM64 code. BUG=

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed as r21317.

Expand Messages | Collapse Messages