Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: third_party/WebKit/public/platform/WebInputEvent.h

Issue 2778853005: Add comments to WebInputEvent for touch enum types. (Closed)
Patch Set: Code review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebInputEvent.h
diff --git a/third_party/WebKit/public/platform/WebInputEvent.h b/third_party/WebKit/public/platform/WebInputEvent.h
index 21d9a47c5c020524a33b2fcae3a18f5ae8c2fbcc..a03918ab84f5138de8748b548666316a6d7e9dbd 100644
--- a/third_party/WebKit/public/platform/WebInputEvent.h
+++ b/third_party/WebKit/public/platform/WebInputEvent.h
@@ -106,33 +106,70 @@ class WebInputEvent {
// WebKeyboardEvent
RawKeyDown,
KeyboardTypeFirst = RawKeyDown,
+ // KeyDown is a single event combining RawKeyDown and Char. If KeyDown is
+ // sent for a given keystroke, those two other events will not be sent.
+ // Platforms tend to prefer sending in one format (Android uses KeyDown,
+ // Windows uses RawKeyDown+Char, for example), but this is a weakly held
+ // property as tools like WebDriver/DevTools might still send the other
+ // format.
KeyDown,
KeyUp,
Char,
KeyboardTypeLast = Char,
- // WebGestureEvent
+ // WebGestureEvent - input interpreted semi-semantically, most commonly from
+ // touchscreen but also used for touchpad, mousewheel, and gamepad
+ // scrolling.
GestureScrollBegin,
GestureTypeFirst = GestureScrollBegin,
GestureScrollEnd,
GestureScrollUpdate,
+ // Fling is a high-velocity and quickly released finger movement.
+ // FlingStart is sent once and kicks off a scroll animation.
GestureFlingStart,
GestureFlingCancel,
+ // Pinch is two fingers moving closer or farther apart.
+ GesturePinchBegin,
+ GesturePinchEnd,
+ GesturePinchUpdate,
+
+ // The following types are variations and subevents of single-taps.
+ //
+ // Sent the moment the user's finger hits the screen.
+ GestureTapDown,
+ // Sent a short interval later, after it seems the finger is staying in
+ // place. It's used to activate the link highlight ("show the press").
GestureShowPress,
+ // Sent on finger lift for a simple, static, quick finger tap. This is the
+ // "main" event which maps to a synthetic mouse click event.
GestureTap,
- GestureTapUnconfirmed,
- GestureTapDown,
+ // Sent when a GestureTapDown didn't turn into any variation of GestureTap
+ // (likely it turned into a scroll instead).
GestureTapCancel,
- GestureDoubleTap,
- GestureTwoFingerTap,
+ // Sent as soon as the long-press timeout fires, while the finger is still
+ // down.
GestureLongPress,
+ // Sent when the finger is lifted following a GestureLongPress.
GestureLongTap,
- GesturePinchBegin,
- GesturePinchEnd,
- GesturePinchUpdate,
- GestureTypeLast = GesturePinchUpdate,
+ // Sent on finger lift when two fingers tapped at the same time without
+ // moving.
+ GestureTwoFingerTap,
+ // A rare event sent in place of GestureTap on desktop pages viewed on an
+ // Android phone. This tap could not yet be resolved into a GestureTap
+ // because it may still turn into a GestureDoubleTap.
+ GestureTapUnconfirmed,
+
+ // Double-tap is two single-taps spread apart in time, like a double-click.
+ // This event is only sent on desktop pages viewed on an Android phone, and
+ // is always preceded by GestureTapUnconfirmed. It's an instruction to
+ // Blink to perform a PageScaleAnimation zoom onto the double-tapped
+ // content. (It's treated differently from GestureTap with tapCount=2,
+ // which can also happen.)
+ GestureDoubleTap,
+
+ GestureTypeLast = GestureDoubleTap,
- // WebTouchEvent
+ // WebTouchEvent - raw touch pointers not yet classified into gestures.
TouchStart,
TouchTypeFirst = TouchStart,
TouchMove,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698