Add comments to WebInputEvent for touch enum types.

third_party/WebKit/public/platform/WebInputEvent.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 88 matching lines @@
     MouseLeave,
     ContextMenu,
     MouseTypeLast = ContextMenu,
 
     // WebMouseWheelEvent
     MouseWheel,
 
     // WebKeyboardEvent
     RawKeyDown,
     KeyboardTypeFirst = RawKeyDown,
+    // KeyDown is a single event combining RawKeyDown and Char.  If KeyDown is

[dtapuska, 2017/03/29 13:01:55]

Probably adding a piece of text here like assuming a platform generates only
KeyDown events is wrong. As DevTools & WebDriver can generate RawKeyDown events.

[aelias_OOO_until_Jul13, 2017/03/29 19:07:53]

Done.

+    // sent, those two other events will not be sent.
     KeyDown,
     KeyUp,
     Char,
     KeyboardTypeLast = Char,
 
-    // WebGestureEvent
+    // WebGestureEvent - touch pointers already interpreted semi-sematically.

[tdresser, 2017/03/29 12:26:48]

sematically -> semantically?

It's a bit tricky, because we also use some of these gestures for wheel
scrolling now.

[aelias_OOO_until_Jul13, 2017/03/29 19:07:55]

Done.

     GestureScrollBegin,
     GestureTypeFirst = GestureScrollBegin,
     GestureScrollEnd,
     GestureScrollUpdate,
+    // Fling is a high-velocity and quickly released finger movement.
+    // FlingStart is sent once and kicks off a scroll animation.
     GestureFlingStart,
     GestureFlingCancel,
-    GestureShowPress,
-    GestureTap,
-    GestureTapUnconfirmed,
-    GestureTapDown,
-    GestureTapCancel,
-    GestureDoubleTap,
-    GestureTwoFingerTap,
-    GestureLongPress,
-    GestureLongTap,
+    // Pinch is two fingers moving closer or farther apart.
     GesturePinchBegin,
     GesturePinchEnd,
     GesturePinchUpdate,
-    GestureTypeLast = GesturePinchUpdate,
 
-    // WebTouchEvent
+    // The following types are variations and subevents of single-taps.
+    //
+    // Sent the moment the user's finger hits the screen.
+    GestureTapDown,
+    // Sent a short interval later, after it seems the finger is staying in
+    // place.  It's used to activate the link highlight ("show the press").
+    GestureShowPress,
+    // Sent on finger lift, if the gesture didn't turn into a scroll.  This is
+    // the "main" event which maps to a synthetic mouse click event.

[tdresser, 2017/03/29 12:26:48]

On long tap, we don't send a tap event, do we?

[aelias_OOO_until_Jul13, 2017/03/29 19:07:54]

Switched to "for a simple, static, quick finger tap"

+    GestureTap,
+    // Sent when a GestureTapDown didn't turn into a GestureTap (likely it
+    // turned into a scroll instead).
+    GestureTapCancel,
+    // Sent as soon as the long-press timeout fires, while the finger is still
+    // down.
+    GestureLongPress,
+    // Sent when the finger is lifted following a GestureLongPress.
+    GestureLongTap,
+    // Sent on finger lift when two fingers tapped at the same time without
+    // moving.
+    GestureTwoFingerTap,
+    // A rare event sent in place of GestureTap on desktop pages viewed on an
+    // Android phone.  This tap could not yet be resolved into a GestureTap
+    // because it may still turn into a GestureDoubleTap.
+    GestureTapUnconfirmed,

[mustaq, 2017/03/29 18:27:28]

Am I right to recall that CrOS also fires GestureTapUnconfirmed?

[aelias_OOO_until_Jul13, 2017/03/29 19:07:53]

No, I had grepped this and only place that sets it is
https://cs.chromium.org/chromium/src/ui/events/gesture_detection/gesture_prov...
.  This can never happen on Aura platforms because of
https://cs.chromium.org/chromium/src/ui/events/gesture_detection/gesture_conf...
makes IsDoubleTapEnabled() return false.

[aelias_OOO_until_Jul13, 2017/03/29 19:10:55]

And in general, there's no appetite at all for shipping double-tap zoom on
non-Android because of the tap delay problem, so I'm not worried that this
comment will become obsolete.  I think it's clarifying to mention that this
event is effectively platform-specific, instead of being intentionally
vague/generic.

[tdresser, 2017/03/29 19:45:55]

+1

+
+    // Double-tap is two single-taps spread apart in time, like a double-click.
+    // This event is only sent on desktop pages viewed on an Android phone, and
+    // is always preceded by GestureTapUnconfirmed.  It's an instruction to
+    // Blink to perform a PageScaleAnimation zoom onto the double-tapped
+    // content.  (It's treated differently from GestureTap with tapCount=2,
+    // which can also happen.)
+    GestureDoubleTap,
+
+    GestureTypeLast = GestureDoubleTap,
+
+    // WebTouchEvent - raw touch pointers not yet classified into gestures.
     TouchStart,
     TouchTypeFirst = TouchStart,
     TouchMove,
     TouchEnd,
     TouchCancel,
     TouchScrollStarted,
     TouchTypeLast = TouchScrollStarted,
 
     TypeLast = TouchTypeLast
   };
@@ skipping 235 matching lines @@
   unsigned m_size;            // The size of this structure, for serialization.
   Type m_type;
   int m_modifiers;
 };
 
 #pragma pack(pop)
 
 }  // namespace blink
 
 #endif