Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 277883002: Add cpu count to trace metadata (Closed)

Created:
6 years, 7 months ago by nduca
Modified:
5 years ago
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add cpu count to trace metadata TBR for analyzer changes, which are just fixes to the analyzer unit tests. R=dsinclair CC=epenner TBR=willchan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272682

Patch Set 1 #

Patch Set 2 : oh naclmore, y u so thrifty #

Patch Set 3 : fix tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M base/debug/trace_event_impl.cc View 1 1 chunk +8 lines, -0 lines 1 comment Download
M base/debug/trace_event_unittest.cc View 1 2 9 chunks +30 lines, -0 lines 0 comments Download
M base/test/trace_event_analyzer.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M base/test/trace_event_analyzer.cc View 1 2 3 chunks +9 lines, -4 lines 0 comments Download
M base/test/trace_event_analyzer_unittest.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
nduca
ptal ... this lets us do coarse estimates of idle time vs cpu load in ...
6 years, 7 months ago (2014-05-09 09:14:34 UTC) #1
dsinclair
lgtm
6 years, 7 months ago (2014-05-09 15:21:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/277883002/1
6 years, 7 months ago (2014-05-09 15:22:41 UTC) #3
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 7 months ago (2014-05-23 22:29:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/277883002/40001
6 years, 7 months ago (2014-05-23 22:32:33 UTC) #5
commit-bot: I haz the power
Change committed as 272682
6 years, 7 months ago (2014-05-24 02:25:27 UTC) #6
Ruud van Asseldonk
5 years ago (2015-12-02 17:00:54 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/277883002/diff/40001/base/debug/trace_event_i...
File base/debug/trace_event_impl.cc (right):

https://codereview.chromium.org/277883002/diff/40001/base/debug/trace_event_i...
base/debug/trace_event_impl.cc:2052: #if !defined(OS_NACL)  // NaCl shouldn't
expose the process id.
Either the comment is wrong, or the #if should not be there. This currently
lives in trace_event/trace_log.cc [1] but this appears to be the origin. What
was the intention here?

[1]:
https://chromium.googlesource.com/chromium/src/+/master/base/trace_event/trac...

Powered by Google App Engine
This is Rietveld 408576698