Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Unified Diff: ash/mus/window_manager.cc

Issue 2778823002: Simplify WindowManager::OnWmSetBounds (Closed)
Patch Set: Update expectations for DragTestInteractive.DragTest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/window_manager.h ('k') | mash/simple_wm/simple_wm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index ccae4d91e0212a5d87c3c114cf13fa21f642228f..1ca8f714ccac3829c4836fd862eb526dc087f8ab 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -316,12 +316,11 @@ void WindowManager::SetWindowManagerClient(aura::WindowManagerClient* client) {
ash::Shell::set_window_manager_client(client);
}
-bool WindowManager::OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) {
+void WindowManager::OnWmSetBounds(aura::Window* window,
+ const gfx::Rect& bounds) {
// TODO(sky): this indirectly sets bounds, which is against what
// OnWmSetBounds() recommends doing. Remove that restriction, or fix this.
- WmWindow::Get(window)->SetBounds(*bounds);
- *bounds = window->bounds();
- return true;
+ WmWindow::Get(window)->SetBounds(bounds);
}
bool WindowManager::OnWmSetProperty(
« no previous file with comments | « ash/mus/window_manager.h ('k') | mash/simple_wm/simple_wm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698