Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: services/ui/ws/window_tree.cc

Issue 2778823002: Simplify WindowManager::OnWmSetBounds (Closed)
Patch Set: Update expectations for DragTestInteractive.DragTest Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/ws/window_tree.h ('k') | ui/aura/mus/window_manager_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/ws/window_tree.h" 5 #include "services/ui/ws/window_tree.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 2052 matching lines...) Expand 10 before | Expand all | Expand 10 after
2063 window->SetBounds(window_server_->GetCurrentMoveLoopRevertBounds(), 2063 window->SetBounds(window_server_->GetCurrentMoveLoopRevertBounds(),
2064 base::nullopt); 2064 base::nullopt);
2065 } 2065 }
2066 2066
2067 window_server_->EndMoveLoop(); 2067 window_server_->EndMoveLoop();
2068 } 2068 }
2069 2069
2070 window_server_->WindowManagerChangeCompleted(change_id, response); 2070 window_server_->WindowManagerChangeCompleted(change_id, response);
2071 } 2071 }
2072 2072
2073 void WindowTree::WmSetBoundsResponse(uint32_t change_id) {
2074 // The window manager will always give a response of false to the client
2075 // because it will always update the bounds of the top level window itself
2076 // which will overwrite the request made by the client.
2077 WmResponse(change_id, false);
2078 }
2079
2073 void WindowTree::WmRequestClose(Id transport_window_id) { 2080 void WindowTree::WmRequestClose(Id transport_window_id) {
2074 ServerWindow* window = 2081 ServerWindow* window =
2075 GetWindowByClientId(ClientWindowId(transport_window_id)); 2082 GetWindowByClientId(ClientWindowId(transport_window_id));
2076 WindowTree* tree = window_server_->GetTreeWithRoot(window); 2083 WindowTree* tree = window_server_->GetTreeWithRoot(window);
2077 if (tree && tree != this) { 2084 if (tree && tree != this) {
2078 tree->client()->RequestClose(tree->ClientWindowIdForWindow(window).id); 2085 tree->client()->RequestClose(tree->ClientWindowIdForWindow(window).id);
2079 } 2086 }
2080 // TODO(sky): think about what else case means. 2087 // TODO(sky): think about what else case means.
2081 } 2088 }
2082 2089
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
2272 client()->OnCompleteDrop(client_window_id.id, event_flags, cursor_offset, 2279 client()->OnCompleteDrop(client_window_id.id, event_flags, cursor_offset,
2273 effect_bitmask, callback); 2280 effect_bitmask, callback);
2274 } 2281 }
2275 2282
2276 void WindowTree::PerformOnDragDropDone() { 2283 void WindowTree::PerformOnDragDropDone() {
2277 client()->OnDragDropDone(); 2284 client()->OnDragDropDone();
2278 } 2285 }
2279 2286
2280 } // namespace ws 2287 } // namespace ws
2281 } // namespace ui 2288 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/ws/window_tree.h ('k') | ui/aura/mus/window_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698