Simplify WindowManager::OnWmSetBounds

ui/aura/mus/window_tree_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/mus/window_tree_client.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 1390 matching lines @@
                                    Id window_id,
                                    const gfx::Rect& transit_bounds_in_pixels) {
   WindowMus* window = GetWindowByServerId(window_id);
   bool result = false;
   if (window) {
     float device_scale_factor = ScaleFactorForDisplay(window->GetWindow());
     DCHECK(window_manager_delegate_);
     gfx::Rect transit_bounds_in_dip =
         gfx::ConvertRectToDIP(device_scale_factor, transit_bounds_in_pixels);
     gfx::Rect bounds_in_dip = transit_bounds_in_dip;
-    // TODO: this needs to trigger scheduling a bounds change on |window|.
-    result = window_manager_delegate_->OnWmSetBounds(window->GetWindow(),
-                                                     &bounds_in_dip);
-    if (result) {
-      // If the resulting bounds differ return false. Returning false ensures
-      // the client applies the bounds we set below.
-      result = bounds_in_dip == transit_bounds_in_dip;
-      window->SetBoundsFromServer(bounds_in_dip);
-    }
+    window_manager_delegate_->OnWmSetBounds(window->GetWindow(),
+                                            &bounds_in_dip);
   } else {
     DVLOG(1) << "Unknown window passed to WmSetBounds().";
   }
   if (window_manager_internal_client_)
     window_manager_internal_client_->WmResponse(change_id, result);

[sadrul, 2017/03/27 17:06:16]

Maybe the WM does not need to ack the bounds change at all?

[Fady Samuel, 2017/03/27 17:11:42]

Right now the window server, and client generate in flight change IDs for this
request. Maybe we don't need these inflight changes?

[sky, 2017/03/27 17:14:56]

Things will get out of order if you do that. I agree with Sadrul. For clarity
please add a WmSetBoundsResponse(change_id) that takes no bool, only the change
id. Mus will always respond with false to the SetBounds request and the client
will do the right thing.

[Fady Samuel, 2017/03/27 18:15:36]

Done.

 }
 
 void WindowTreeClient::WmSetProperty(
     uint32_t change_id,
     Id window_id,
     const std::string& name,
     const base::Optional<std::vector<uint8_t>>& transit_data) {
   WindowMus* window = GetWindowByServerId(window_id);
   bool result = false;
   if (window) {
@@ skipping 480 matching lines @@
   return ScheduleInFlightChange(base::MakeUnique<InFlightCaptureChange>(
       this, capture_synchronizer_.get(), window));
 }
 
 uint32_t WindowTreeClient::CreateChangeIdForFocus(WindowMus* window) {
   return ScheduleInFlightChange(base::MakeUnique<InFlightFocusChange>(
       this, focus_synchronizer_.get(), window));
 }
 
 }  // namespace aura